users/jgh/exim.git
5 years agotidying
Jeremy Harris [Wed, 4 Sep 2019 14:19:42 +0000 (15:19 +0100)]
tidying

5 years agoFix taint-checking on FreeBSD
Jeremy Harris [Wed, 4 Sep 2019 10:07:34 +0000 (11:07 +0100)]
Fix taint-checking on FreeBSD

5 years agotidying
Jeremy Harris [Tue, 3 Sep 2019 20:49:58 +0000 (21:49 +0100)]
tidying

5 years agoTestsuite: platform differences for resolver flags bits
Jeremy Harris [Mon, 2 Sep 2019 11:33:29 +0000 (12:33 +0100)]
Testsuite: platform differences for resolver flags bits

5 years agoBuild: another go at Solaris workarounds
Jeremy Harris [Mon, 2 Sep 2019 10:18:48 +0000 (11:18 +0100)]
Build: another go at Solaris workarounds

5 years agoTestsuite: keep noqualify testcase from using external DNS
Jeremy Harris [Sun, 1 Sep 2019 22:45:43 +0000 (23:45 +0100)]
Testsuite: keep noqualify testcase from using external DNS

5 years agoTestsuite: platform differences for resolver flags bits
Jeremy Harris [Sun, 1 Sep 2019 20:47:11 +0000 (21:47 +0100)]
Testsuite: platform differences for resolver flags bits

5 years agoTestsuite: fix non-ipv6 platforms
Jeremy Harris [Sun, 1 Sep 2019 19:43:02 +0000 (20:43 +0100)]
Testsuite: fix non-ipv6 platforms

Broken-by: 7d8d08c484
5 years agoSupport TTL from SOA for NXDOMAIN & NODATA cache entries. Bug 1395
Jeremy Harris [Sun, 1 Sep 2019 18:44:31 +0000 (19:44 +0100)]
Support TTL from SOA for NXDOMAIN & NODATA cache entries.  Bug 1395

5 years agoAlways check return from tls_export_cert()
Heiko Schlittermann (HS12-RIPE) [Fri, 30 Aug 2019 11:44:01 +0000 (13:44 +0200)]
Always check return from tls_export_cert()

Invert the meaning of the return.

5 years agoTestcase for handling of -H files for excessive long '-KEY' lines
Heiko Schlittermann (HS12-RIPE) [Tue, 27 Aug 2019 19:58:27 +0000 (21:58 +0200)]
Testcase for handling of -H files for excessive long '-KEY' lines

Thanks to Qualys for their analysis. This bug was fixed independently
by JGH.

Tidy.

5 years agoFix ${domain:} for a bare local-part input. Bug 2375
Jeremy Harris [Tue, 27 Aug 2019 16:44:52 +0000 (17:44 +0100)]
Fix ${domain:} for a bare local-part input.  Bug 2375

Broken-by: e2ff8e24f4
5 years agotypos
Jeremy Harris [Mon, 19 Aug 2019 19:06:32 +0000 (20:06 +0100)]
typos

5 years agoBuild: workaround inlining problems on Solaris
Jeremy Harris [Mon, 19 Aug 2019 18:32:01 +0000 (19:32 +0100)]
Build: workaround inlining problems on Solaris

5 years agotaint SNI values supplied by client
Jeremy Harris [Mon, 19 Aug 2019 14:50:57 +0000 (15:50 +0100)]
taint SNI values supplied by client

5 years agoBuild: workaround inlining problems on Solaris
Jeremy Harris [Mon, 19 Aug 2019 14:25:38 +0000 (15:25 +0100)]
Build: workaround inlining problems on Solaris

5 years agoTestsuite: DNS lookup notes
Jeremy Harris [Mon, 19 Aug 2019 13:23:11 +0000 (14:23 +0100)]
Testsuite: DNS lookup notes

5 years agotaint nonrcpt names read from spool
Jeremy Harris [Mon, 19 Aug 2019 11:03:46 +0000 (12:03 +0100)]
taint nonrcpt names read from spool

5 years agoinlining
Jeremy Harris [Mon, 19 Aug 2019 10:51:43 +0000 (11:51 +0100)]
inlining

5 years agoAppendfile: when evaluating quota use attemd to link counts
Jeremy Harris [Thu, 15 Aug 2019 12:47:04 +0000 (13:47 +0100)]
Appendfile: when evaluating quota use attemd to link counts

5 years agoTestsuite: not all builds include SPF
Jeremy Harris [Wed, 14 Aug 2019 12:32:11 +0000 (13:32 +0100)]
Testsuite: not all builds include SPF

5 years agoSPF: split library init from per-connection init
Jeremy Harris [Tue, 13 Aug 2019 21:33:50 +0000 (22:33 +0100)]
SPF: split library init from per-connection init

5 years agoDMARC: Use exim facilities for DNS lookups
Jeremy Harris [Tue, 13 Aug 2019 12:34:30 +0000 (13:34 +0100)]
DMARC: Use exim facilities for DNS lookups

This enables teststing with the testsuite

5 years agoDNS: use tainted memory for all lookups
Jeremy Harris [Tue, 13 Aug 2019 11:50:38 +0000 (12:50 +0100)]
DNS: use tainted memory for all lookups

5 years agoSPF: use exim facilities for DNS lookups
Jeremy Harris [Tue, 13 Aug 2019 10:58:10 +0000 (11:58 +0100)]
SPF: use exim facilities for DNS lookups

This enables testing with the testsuite

5 years agoDKIM: preferences for verify algorithms
Jeremy Harris [Sat, 10 Aug 2019 16:58:22 +0000 (17:58 +0100)]
DKIM: preferences for verify algorithms

5 years agoRouters: make retry_use_local_part default true when any non-domain condition is...
Jeremy Harris [Thu, 1 Aug 2019 18:31:36 +0000 (19:31 +0100)]
Routers: make retry_use_local_part default true when any non-domain condition is present.  Bug 2408

5 years agoFix ipv6-less build
Jeremy Harris [Sat, 10 Aug 2019 17:29:26 +0000 (18:29 +0100)]
Fix ipv6-less build

Broken-by: de2e5b3dc6
5 years agoDKIM: use tainted mem for dns lookup
Jeremy Harris [Sat, 10 Aug 2019 16:56:30 +0000 (17:56 +0100)]
DKIM: use tainted mem for dns lookup

5 years agoconstify
Jeremy Harris [Sat, 10 Aug 2019 16:55:16 +0000 (17:55 +0100)]
constify

5 years agoLookups: support IPv6 addresses in the spf lookup type. Bug 2378
Jeremy Harris [Sun, 4 Aug 2019 13:38:18 +0000 (14:38 +0100)]
Lookups: support IPv6 addresses in the spf lookup type.  Bug 2378

5 years agoCallouts: filter smtp response for bad chars before using in our smtp response. ...
Jeremy Harris [Sat, 3 Aug 2019 21:22:58 +0000 (22:22 +0100)]
Callouts: filter smtp response for bad chars before using in our smtp response.  Bug 2409

5 years agocompiler quietening
Jeremy Harris [Sat, 3 Aug 2019 15:42:19 +0000 (16:42 +0100)]
compiler quietening

5 years agoFix bogus taint coding in setenv
Jeremy Harris [Sat, 3 Aug 2019 15:40:14 +0000 (16:40 +0100)]
Fix bogus taint coding in setenv

This probably only affects Solaris; where it broke the build

5 years agoBuild: workaround inlining problems on Solaris
Jeremy Harris [Sat, 3 Aug 2019 13:18:38 +0000 (14:18 +0100)]
Build: workaround inlining problems on Solaris
Also fix for difference in syscall types for munmap()

5 years agopreallocate store for config
Jeremy Harris [Sat, 6 Jul 2019 21:17:04 +0000 (22:17 +0100)]
preallocate store for config

5 years agoAuth: handle socket read errors in Dovecot authenticator
Bruce Lee [Tue, 30 Jul 2019 21:43:14 +0000 (22:43 +0100)]
Auth: handle socket read errors in Dovecot authenticator

5 years agotidying
Jeremy Harris [Tue, 30 Jul 2019 21:32:08 +0000 (22:32 +0100)]
tidying

5 years agoFix build on OpenBSD
Jeremy Harris [Mon, 29 Jul 2019 16:11:03 +0000 (17:11 +0100)]
Fix build on OpenBSD

5 years agoFix taint-checking on OpenBSD
Jeremy Harris [Mon, 29 Jul 2019 14:48:05 +0000 (15:48 +0100)]
Fix taint-checking on OpenBSD

5 years agotestsuite: interlock callout tests
Jeremy Harris [Sun, 28 Jul 2019 16:34:23 +0000 (17:34 +0100)]
testsuite: interlock callout tests

5 years agoFix crash after TLS channel shutdown
Jeremy Harris [Sun, 28 Jul 2019 13:47:29 +0000 (14:47 +0100)]
Fix crash after TLS channel shutdown

5 years agoBuild: workaround inlining problems on Solaris
Jeremy Harris [Sat, 27 Jul 2019 16:11:09 +0000 (17:11 +0100)]
Build: workaround inlining problems on Solaris

5 years agoTestsuite: try to trace intermittent callout fails
Jeremy Harris [Sat, 27 Jul 2019 15:14:51 +0000 (16:14 +0100)]
Testsuite: try to trace intermittent callout fails

5 years agoBuild: workaround inlining problems on Solaris
Jeremy Harris [Sat, 27 Jul 2019 14:00:58 +0000 (15:00 +0100)]
Build: workaround inlining problems on Solaris

5 years agoTestsuite: try to trace intermittent callout fails
Jeremy Harris [Thu, 25 Jul 2019 20:42:24 +0000 (21:42 +0100)]
Testsuite: try to trace intermittent callout fails

5 years agoBuild: workaround inlining problems on Solaris
Jeremy Harris [Thu, 25 Jul 2019 19:09:18 +0000 (20:09 +0100)]
Build: workaround inlining problems on Solaris

5 years agoDe-taint library-return string for inet_ntoa() etc
Jeremy Harris [Thu, 25 Jul 2019 18:41:57 +0000 (19:41 +0100)]
De-taint library-return string for inet_ntoa() etc

5 years agoinlining
Jeremy Harris [Thu, 25 Jul 2019 14:34:10 +0000 (15:34 +0100)]
inlining

5 years agoFix dkim_strict expansion. Bug 2413
Ruben Jenster [Fri, 19 Jul 2019 11:56:56 +0000 (12:56 +0100)]
Fix dkim_strict expansion.  Bug 2413

Broken since the introduction of dkim support.
Testsuite additions by jgh

5 years agoTrack tainted data and refuse to expand it
Jeremy Harris [Thu, 25 Jul 2019 11:06:07 +0000 (12:06 +0100)]
Track tainted data and refuse to expand it

5 years agoAvoid re-expansion in ${sort }
Jeremy Harris [Fri, 5 Jul 2019 14:38:15 +0000 (15:38 +0100)]
Avoid re-expansion in ${sort }

5 years agoTestsuite: Debug: indent lowlevel connect result
Jeremy Harris [Mon, 22 Jul 2019 09:13:42 +0000 (10:13 +0100)]
Testsuite: Debug: indent lowlevel connect result

5 years agoTestsuite: better non-TFO-system debug handling
Jeremy Harris [Sat, 20 Jul 2019 21:47:57 +0000 (22:47 +0100)]
Testsuite: better non-TFO-system debug handling

5 years agoDebug: indent lowlevel connect result
Jeremy Harris [Sat, 20 Jul 2019 19:58:24 +0000 (20:58 +0100)]
Debug: indent lowlevel connect result

5 years agoTestsuite: synch log output
Jeremy Harris [Sat, 20 Jul 2019 14:25:23 +0000 (15:25 +0100)]
Testsuite: synch log output

5 years agoDocs: more indexing for sighup
Jeremy Harris [Wed, 17 Jul 2019 09:10:33 +0000 (10:10 +0100)]
Docs: more indexing for sighup

5 years agoRouter variables: change list-separator to semicolon
Jeremy Harris [Mon, 15 Jul 2019 11:51:42 +0000 (12:51 +0100)]
Router variables: change list-separator to semicolon

5 years agoDocs: add note on unusablility of must-staple certs by clients. Bug 2350
Jeremy Harris [Mon, 15 Jul 2019 09:53:35 +0000 (10:53 +0100)]
Docs: add note on unusablility of must-staple certs by clients.  Bug 2350

5 years agoRouter variables: local visibiliity
Jeremy Harris [Thu, 11 Jul 2019 22:35:20 +0000 (23:35 +0100)]
Router variables: local visibiliity

5 years agoKeep router-variables separate on addrs, to avoid taint contamination
Jeremy Harris [Thu, 11 Jul 2019 16:12:26 +0000 (17:12 +0100)]
Keep router-variables separate on addrs, to avoid taint contamination

5 years agotidying
Jeremy Harris [Thu, 11 Jul 2019 15:17:34 +0000 (16:17 +0100)]
tidying

5 years agoDebug: indent lookup operations
Jeremy Harris [Thu, 11 Jul 2019 10:58:07 +0000 (11:58 +0100)]
Debug: indent lookup operations

5 years agoExpansions: acl expansion error detail
Jeremy Harris [Tue, 9 Jul 2019 21:43:18 +0000 (22:43 +0100)]
Expansions: acl expansion error detail

5 years agoRouters: named variables
Jeremy Harris [Mon, 8 Jul 2019 16:34:47 +0000 (17:34 +0100)]
Routers: named variables

5 years agoDocs: more indexing
Jeremy Harris [Mon, 8 Jul 2019 15:39:46 +0000 (16:39 +0100)]
Docs: more indexing

5 years agoMicrofix in SECURITY.md: exim-VERSION+fixes
Heiko Schlittermann (HS12-RIPE) [Sat, 6 Jul 2019 21:34:06 +0000 (23:34 +0200)]
Microfix in SECURITY.md: exim-VERSION+fixes

5 years agomore function attribute annotation
Jeremy Harris [Sat, 6 Jul 2019 19:44:45 +0000 (20:44 +0100)]
more function attribute annotation

5 years agoAdd missing feature lines to prototype Makefile
Jeremy Harris [Tue, 2 Jul 2019 21:23:49 +0000 (22:23 +0100)]
Add missing feature lines to prototype Makefile

5 years agoFix bounce generation under RFC 3461 request. Bug 2411
Jeremy Harris [Sat, 29 Jun 2019 18:31:23 +0000 (19:31 +0100)]
Fix bounce generation under RFC 3461 request.  Bug 2411

Broken-by: ea97267cea
5 years agoBuild: bodge attempt to get Solaris build working
Jeremy Harris [Sat, 29 Jun 2019 13:42:37 +0000 (14:42 +0100)]
Build: bodge attempt to get Solaris build working

5 years agoDocs: add note on effects of disabling IPv6 lookups
Jeremy Harris [Thu, 27 Jun 2019 19:59:26 +0000 (20:59 +0100)]
Docs: add note on effects of disabling IPv6 lookups

5 years agoCompiler quietening
Jeremy Harris [Wed, 26 Jun 2019 11:39:33 +0000 (12:39 +0100)]
Compiler quietening

Trying to set an enum (int-sized) with top bit set, needs a cast to (signed) int.
Broken-by: ae8f9024d8
5 years agoTestsuite: output changes resulting
Jeremy Harris [Wed, 26 Jun 2019 11:36:49 +0000 (12:36 +0100)]
Testsuite: output changes resulting

Broken-by: 436bda2ac0
5 years agoFix DSN Final-Recipient: field
Jeremy Harris [Wed, 26 Jun 2019 09:59:44 +0000 (10:59 +0100)]
Fix DSN Final-Recipient: field

5 years agotidying
Jeremy Harris [Mon, 3 Jun 2019 12:55:04 +0000 (13:55 +0100)]
tidying

5 years agoDebug: more gentle line-drawing chars
Jeremy Harris [Mon, 24 Jun 2019 14:15:55 +0000 (15:15 +0100)]
Debug: more gentle line-drawing chars

5 years agoAdd a security page in a place where GitHub will detect it
Phil Pennock [Wed, 19 Jun 2019 19:37:19 +0000 (15:37 -0400)]
Add a security page in a place where GitHub will detect it

5 years agoInline the smaller string-handling functions
Jeremy Harris [Sun, 16 Jun 2019 17:10:59 +0000 (18:10 +0100)]
Inline the smaller string-handling functions

5 years agoFix detection of 32b platform at build time. Bug 2405
Jeremy Harris [Fri, 7 Jun 2019 10:54:10 +0000 (11:54 +0100)]
Fix detection of 32b platform at build time.  Bug 2405

5 years agoFix smtp response timeout
Jeremy Harris [Mon, 27 May 2019 22:44:31 +0000 (23:44 +0100)]
Fix smtp response timeout

5 years agoUse dsn_from for success-DSN messages. Bug 2404
Jeremy Harris [Tue, 4 Jun 2019 17:13:21 +0000 (18:13 +0100)]
Use dsn_from for success-DSN messages.  Bug 2404

5 years agoUnbreak heimdal_gssapi auth driver
Phil Pennock [Wed, 5 Jun 2019 09:35:28 +0000 (05:35 -0400)]
Unbreak heimdal_gssapi auth driver

Commit 251b9eb46 broke heimdal_gssapi by changing the function
definition in the `.c` without changing the declaration in the `.h`.
Was part of 4.92.

Make corresponding `.h` change to reflect newer internal API.

5 years agoTestsuite: compat vs. older GnuTLS
Jeremy Harris [Tue, 4 Jun 2019 15:06:27 +0000 (16:06 +0100)]
Testsuite: compat vs. older GnuTLS

5 years agoEvents: avoid evaluating intermediates for unneeded events
Jeremy Harris [Tue, 4 Jun 2019 13:18:59 +0000 (14:18 +0100)]
Events: avoid evaluating intermediates for unneeded events

5 years agoTestsuite: platform variances
Jeremy Harris [Wed, 29 May 2019 13:14:24 +0000 (14:14 +0100)]
Testsuite: platform variances

5 years agoTestsuite: platform variances
Jeremy Harris [Tue, 28 May 2019 22:38:34 +0000 (23:38 +0100)]
Testsuite: platform variances

5 years agoTestsuite: library variances for ARC testcase
Jeremy Harris [Tue, 28 May 2019 20:04:47 +0000 (21:04 +0100)]
Testsuite: library variances for ARC testcase

5 years agoPIPE_CONNECT: promote from experimental
Jeremy Harris [Tue, 28 May 2019 19:02:50 +0000 (20:02 +0100)]
PIPE_CONNECT: promote from experimental

5 years agoPIPE_CONNECT: avoid using when the transport helo_data uses $sending_ip_address
Jeremy Harris [Mon, 27 May 2019 23:26:48 +0000 (00:26 +0100)]
PIPE_CONNECT: avoid using when the transport helo_data uses $sending_ip_address

5 years agoTestsuite: add missing testcase script
Jeremy Harris [Mon, 27 May 2019 21:06:10 +0000 (22:06 +0100)]
Testsuite: add missing testcase script

Broken-by: c09dbcfb71
5 years agoTFO: change the default for hosts_try_fastopen, enabling use by default
Jeremy Harris [Sun, 26 May 2019 14:42:32 +0000 (15:42 +0100)]
TFO: change the default for hosts_try_fastopen, enabling use by default

5 years agoTestsuite: workaround older kernels
Jeremy Harris [Sun, 26 May 2019 15:28:21 +0000 (16:28 +0100)]
Testsuite: workaround older kernels

Broken-by: 38da908828
5 years agoTestsuite: workaround TFO blackhole detection
Jeremy Harris [Sun, 26 May 2019 13:03:00 +0000 (14:03 +0100)]
Testsuite: workaround TFO blackhole detection

5 years agoTestsuite: ensure TFO not used when not wanted
Jeremy Harris [Sun, 26 May 2019 12:38:41 +0000 (13:38 +0100)]
Testsuite: ensure TFO not used when not wanted

5 years agoDebug: align tracing out for TFO connections with plain ones
Jeremy Harris [Sun, 26 May 2019 10:52:55 +0000 (11:52 +0100)]
Debug: align tracing out for TFO connections with plain ones

5 years agoLogging: avoid claiming a host was used for an addr, when conn refused under TFO
Jeremy Harris [Sat, 25 May 2019 14:18:19 +0000 (15:18 +0100)]
Logging: avoid claiming a host was used for an addr, when conn refused under TFO

5 years agoLogging: fix duplicated transport target info under TFO
Jeremy Harris [Tue, 21 May 2019 20:32:34 +0000 (21:32 +0100)]
Logging: fix duplicated transport target info under TFO

5 years agoCallouts: simplfy debug output
Jeremy Harris [Sat, 25 May 2019 21:43:23 +0000 (22:43 +0100)]
Callouts: simplfy debug output

5 years agoCallouts: simplfy logging
Jeremy Harris [Sat, 25 May 2019 14:48:11 +0000 (15:48 +0100)]
Callouts: simplfy logging