Tidying: coverity issues

diff --git a/src/src/lookups/lf_quote.c b/src/src/lookups/lf_quote.c
index 86cdeef2857564e73db76a1bd92deea24c0e9212..2a76756e9cf417c2febeec6456424ae2fc12488a 100644 (file)
--- a/src/src/lookups/lf_quote.c
+++ b/src/src/lookups/lf_quote.c
@@ -37,7 +37,11 @@ result = string_append(result, asize, aoffset, 2, name, US"=");
 
 /* NULL is handled as an empty string */
 
 
 /* NULL is handled as an empty string */
 

-if (value == NULL) value = US"";
+if (!value)
+  {
+  value = US"";
+  vlength = 0;
+  }

 
 /* Quote the value if it is empty, contains white space, or starts with a quote
 character. */
 
 /* Quote the value if it is empty, contains white space, or starts with a quote
 character. */

diff --git a/src/src/transports/pipe.c b/src/src/transports/pipe.c
index 5ebd64f320f5186a7c73db51a330bd80754f4d17..db522e54bdc65be91f76673919f0610d7321df7b 100644 (file)
--- a/src/src/transports/pipe.c
+++ b/src/src/transports/pipe.c
@@ -489,11 +489,12 @@ if (expand_arguments)
 
     for (ad = addr; ad != NULL; ad = ad->next)
       {
 
     for (ad = addr; ad != NULL; ad = ad->next)
       {

-      if (ad != addr) string_catn(s, &size, &offset, US" ", 1);
-      string_cat(s, &size, &offset, ad->address);
+      /*XXX string_append_listele() ? */
+      if (ad != addr) s = string_catn(s, &size, &offset, US" ", 1);
+      s = string_cat(s, &size, &offset, ad->address);

       }
 
       }
 

-    string_cat(s, &size, &offset, q);
+    s = string_cat(s, &size, &offset, q);

     s[offset] = 0;
     }
 
     s[offset] = 0;
     }