Fix DISABLE_DKIM build & test. Fix build on systems lacking MAX in standard includes.

Broken-by: 44bc8f0c2f35

diff --git a/src/src/macros.h b/src/src/macros.h
index c62f16e7d27251ced9ff8628a8f1bf6004af7e3d..1b7cf4abf64d822a01e65861f4f352384f194e3a 100644 (file)
--- a/src/src/macros.h
+++ b/src/src/macros.h
@@ -15,6 +15,11 @@ a string as a text string. This is sometimes useful for debugging output. */
 /* Number of elements of an array */
 #define nelem(arr) (sizeof(arr) / sizeof(*arr))
 
+/* Maximum of two items */
+#ifndef MAX
+# define MAX(a,b) ((a) > (b) ? (a) : (b))
+#endif
+
 
 /* When running in the test harness, the load average is fudged. */
 

diff --git a/src/src/smtp_in.c b/src/src/smtp_in.c
index 8994c6edb8d2b242861987c97be2f6c4a54aca20..6c9afc501f99b458ad8c5c8a8b5cfa0ff74ed774 100644 (file)
--- a/src/src/smtp_in.c
+++ b/src/src/smtp_in.c
@@ -352,15 +352,15 @@ if (smtp_inptr >= smtp_inend)
 return *smtp_inptr++;
 }
 
-#ifndef DISABLE_DKIM
 void
 smtp_get_cache(void)
 {
+#ifndef DISABLE_DKIM
 int n = smtp_inend - smtp_inptr;
 if (n > 0)
   dkim_exim_verify_feed(smtp_inptr, n);
-}
 #endif
+}
 
 
 /* Get a byte from the smtp input, in CHUNKING mode.  Handle ack of the

diff --git a/src/src/tls-gnu.c b/src/src/tls-gnu.c
index 0774850cae8f77947c2e72a02ecbb136f9c6c8fa..c9dc4d9be02359ad29a8484d27dd485aea72f15e 100644 (file)
--- a/src/src/tls-gnu.c
+++ b/src/src/tls-gnu.c
@@ -2219,16 +2219,16 @@ if (state->xfer_buffer_lwm >= state->xfer_buffer_hwm)
 return state->xfer_buffer[state->xfer_buffer_lwm++];
 }
 
-#ifndef DISABLE_DKIM
 void
 tls_get_cache()
 {
+#ifndef DISABLE_DKIM
 exim_gnutls_state_st * state = &state_server;
 int n = state->xfer_buffer_hwm - state->xfer_buffer_lwm;
 if (n > 0)
   dkim_exim_verify_feed(state->xfer_buffer+state->xfer_buffer_lwm, n);
-}
 #endif
+}
 
 
 

diff --git a/src/src/tls-openssl.c b/src/src/tls-openssl.c
index 242394f95ccc72be30c404888ce7106e64d2f1f2..229ea413123c52f222cf9571540c8f182b33b162 100644 (file)
--- a/src/src/tls-openssl.c
+++ b/src/src/tls-openssl.c
@@ -2360,15 +2360,15 @@ if (ssl_xfer_buffer_lwm >= ssl_xfer_buffer_hwm)
 return ssl_xfer_buffer[ssl_xfer_buffer_lwm++];
 }
 
-#ifndef DISABLE_DKIM
 void
 tls_get_cache()
 {
+#ifndef DISABLE_DKIM
 int n = ssl_xfer_buffer_hwm - ssl_xfer_buffer_lwm;
 if (n > 0)
   dkim_exim_verify_feed(ssl_xfer_buffer+ssl_xfer_buffer_lwm, n);
-}
 #endif
+}
 
 
 

diff --git a/test/confs/0900 b/test/confs/0900
index 427669c4bf1e29a61cb9c9a2c0c37659e5b8faaa..52678e45d59b75ec29edaed8840d35e498184051 100644 (file)
--- a/test/confs/0900
+++ b/test/confs/0900
@@ -1,6 +1,5 @@
 # Exim test configuration 0900
 SERVER=
-X=
 Y=
 OPT=
 ALLOW=
@@ -103,12 +102,14 @@ remote_smtp_dkim:
   command_timeout = 2s
   final_timeout = 2s
 
+.ifdef X
   dkim_domain =                test.ex
   dkim_selector =      sel
   dkim_private_key =   DIR/aux-fixed/dkim/dkim.private
 .ifndef HEADERS_MAXSIZE
   dkim_sign_headers =  OPT
 .endif
+.endif
 
 # ----- Retry -----