GnuTLS: fix the advertising of acceptable certs by the server. Bug 2389
authorJeremy Harris <jgh146exb@wizmail.org>
Sun, 19 May 2019 11:12:36 +0000 (12:12 +0100)
committerJeremy Harris <jgh146exb@wizmail.org>
Sun, 19 May 2019 13:47:42 +0000 (14:47 +0100)
(cherry picked from commit 12d95aa62042377fc9f603245a17a43142972447)

doc/doc-txt/ChangeLog
src/src/tls-gnu.c

index 6c16f12d6bc233f9b51ffe917e997ddb4b0aa4a4..5a3e453d6aea01059a3b3dce1c038337072e9adf 100644 (file)
@@ -61,6 +61,10 @@ JH/19 Bug 2398: fix listing of a named-queue.  Previously, even with the option
       queue_list_requires_admin set to false, non-admin users were denied the
       facility.
 
+JH/20 Bug 2389: fix server advertising of usable certificates, under GnuTLS in
+      directory-of-certs mode.  Previously they were advertised despite the
+      documentation.
+
 
 Exim version 4.92
 -----------------
index 746eabfdeb4f6f9411afef84f8fd6153006f4788..867dbbe3dd8a438bcb1a951011068c39ab30e8d3 100644 (file)
@@ -1136,6 +1136,14 @@ else
 #endif
     gnutls_certificate_set_x509_trust_file(state->x509_cred,
       CS state->exp_tls_verify_certificates, GNUTLS_X509_FMT_PEM);
+
+#ifdef SUPPORT_CA_DIR
+  /* Mimic the behaviour with OpenSSL of not advertising a usable-cert list
+  when using the directory-of-certs config model. */
+
+  if ((statbuf.st_mode & S_IFMT) == S_IFDIR)
+    gnutls_certificate_send_x509_rdn_sequence(state->session, 1);
+#endif
   }
 
 if (cert_count < 0)