Tidying: coverity issues

[users/jgh/exim.git] / test / t / 00-basic.t

diff --git a/test/t/00-basic.t b/test/t/00-basic.t
index a131b762faf2bfb19c857a78439f73a61c6397db..092591e442b7d5be9f5561a3018a1e28dadccdea 100644 (file)
--- a/test/t/00-basic.t
+++ b/test/t/00-basic.t
@@ -1,21 +1,50 @@
 use Test::More;
 use Test::More;

+use Test::Pod::Coverage;
+use Test::Exception;
+

 use lib 'lib';
 use lib 'lib';

-use_ok 'Exim::Runtest' or BAIL_OUT 'Can not load the module';
+use_ok 'Exim::Runtest', qw(:all) or BAIL_OUT 'Can not load the module';

 
 

-can_ok 'Exim::Runtest', qw(mailgroup);
+can_ok 'Exim::Runtest', qw(mailgroup dynamic_socket exim_binary flavour flavours);
+pod_coverage_ok 'Exim::Runtest' => 'docs complete';

 
 subtest 'mailgroup' => sub {
     my $group = getgrgid $(;
     ok $group => 'got a group name';
 
 subtest 'mailgroup' => sub {
     my $group = getgrgid $(;
     ok $group => 'got a group name';

-    diag "use group $group";
+    note "use group $group";

 
 

-    is Exim::Runtest::mailgroup($group), $group => 'group names match';
-    ok $group = Exim::Runtest::mailgroup('non existing group') => 'cope with unknown group';
-    diag "got random group: $group";
+    is mailgroup($group), $group => 'group names match';
+    ok $group = mailgroup('non existing group') => 'cope with unknown group';
+    note "got random group: $group";

 
     ok getgrnam($group) => 'got an existing group';
 
     ok getgrnam($group) => 'got an existing group';

+
+    dies_ok { mailgroup(22) } 'dies on numeric group';
+    dies_ok { mailgroup() } 'dies on missing default group';
+};
+
+subtest 'dynamic_socket' => sub {
+    ok my $socket = dynamic_socket() => 'got a socket';
+    note "got socket on port @{[$socket->sockport]}";
+    isa_ok $socket => 'IO::Socket::INET';
+    cmp_ok $socket->sockport(), '>=', 1024 => 'port is >= 1024';
+    $socket->close;

 };
 
 };
 

+subtest 'exim_binary' => sub {
+    my @argv1 = qw(/bin/sh a b);
+    my @argv2 = qw(t/samples/foo a b);
+    chomp(my $cwd = `pwd`); # don't use Cwd, as we use Cwd in the tested module already
+    is_deeply [exim_binary(@argv1)], \@argv1 => 'got the binary as abs path from argv';
+    is_deeply [exim_binary(@argv2)], ["$cwd/t/samples/foo", @argv2[1,$#argv2]] => 'got the binary as rel path from argv';
+};

 
 

+subtest 'flavour' => sub {
+    is flavour('t/samples/debian8+os-release/etc'), 'debian8' => 'got flavour debian8 from os-release';
+    is flavour('t/samples/debian8+debian-version/etc'), 'debian8' => 'got flavour debian8 from debian_version';
+    is flavour('t/samples/debian.sid/etc'), 'debian' => 'got flavour debian from debian sid w/o VERSION_ID';
+    is flavour('t/samples/fedora24/etc'), 'fedora24' => 'got flavour fedora24 from os-release';
+    is_deeply [flavours()], ['debian8'] => 'got available flavours';
+};

 
 done_testing;
 
 done_testing;