git://git.exim.org
/
users
/
heiko
/
exim.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Check ARGV before subscripting it
[users/heiko/exim.git]
/
src
/
exim_monitor
/
em_log.c
diff --git
a/src/exim_monitor/em_log.c
b/src/exim_monitor/em_log.c
index baa4c8996cb06b391d21df5ef1f2168dc3944f67..69e63533cf4b2d06f1ac0499fc09cdde65a2ad8b 100644
(file)
--- a/
src/exim_monitor/em_log.c
+++ b/
src/exim_monitor/em_log.c
@@
-2,7
+2,7
@@
* Exim Monitor *
*************************************************/
* Exim Monitor *
*************************************************/
-/* Copyright (c) University of Cambridge 1995 - 20
09
*/
+/* Copyright (c) University of Cambridge 1995 - 20
17
*/
/* See the file NOTICE for conditions of use and distribution. */
/* This module contains code for scanning the main log,
/* See the file NOTICE for conditions of use and distribution. */
/* This module contains code for scanning the main log,
@@
-217,7
+217,11
@@
uschar buffer[log_buffer_len];
if (LOG != NULL)
{
if (LOG != NULL)
{
- fseek(LOG, log_position, SEEK_SET);
+ if (fseek(LOG, log_position, SEEK_SET))
+ {
+ perror("logfile fseek");
+ exit(1);
+ }
while (Ufgets(buffer, log_buffer_len, LOG) != NULL)
{
while (Ufgets(buffer, log_buffer_len, LOG) != NULL)
{
@@
-277,12
+281,8
@@
if (LOG != NULL)
if (strstric(buffer, US"frozen", FALSE) != NULL)
{
queue_item *qq = find_queue(id, queue_noop, 0);
if (strstric(buffer, US"frozen", FALSE) != NULL)
{
queue_item *qq = find_queue(id, queue_noop, 0);
- if (qq != NULL)
- {
- if (strstric(buffer, US"unfrozen", FALSE) != NULL)
- qq->frozen = FALSE;
- else qq->frozen = TRUE;
- }
+ if (qq)
+ qq->frozen = strstric(buffer, US"unfrozen", FALSE) == NULL;
}
/* Notice defer messages, and add the destination if it
}
/* Notice defer messages, and add the destination if it
@@
-364,7
+364,9
@@
link count of zero on the currently open file. */
if (log_datestamping)
{
uschar log_file_wanted[256];
if (log_datestamping)
{
uschar log_file_wanted[256];
- string_format(log_file_wanted, sizeof(log_file_wanted), "%s", CS log_file);
+ /* Do *not* use "%s" here, we need the %D datestamp in the log_file to
+ * be expanded! */
+ string_format(log_file_wanted, sizeof(log_file_wanted), CS log_file);
if (Ustrcmp(log_file_wanted, log_file_open) != 0)
{
if (LOG != NULL)
if (Ustrcmp(log_file_wanted, log_file_open) != 0)
{
if (LOG != NULL)
@@
-391,7
+393,11
@@
if (LOG == NULL ||
{
if (LOG != NULL) fclose(LOG);
LOG = TEST;
{
if (LOG != NULL) fclose(LOG);
LOG = TEST;
- fstat(fileno(LOG), &statdata);
+ if (fstat(fileno(LOG), &statdata))
+ {
+ fprintf(stderr, "fstat %s: %s\n", log_file_open, strerror(errno));
+ exit(1);
+ }
log_inode = statdata.st_ino;
}
}
log_inode = statdata.st_ino;
}
}