int spam_rc = 0;
uschar *prev_spamd_address_work = NULL;
+static int timeout_sec;
static const uschar * loglabel = US"spam acl condition:";
+
static int
spamd_param_init(spamd_address_container *spamd)
{
spamd_param(const uschar *param, spamd_address_container *spamd)
{
static int timesinceday = -1;
-uschar buffer[256];
+const uschar * s;
/* check backup parameter */
if (Ustrcmp(param, "backup") == 0)
}
/* check time parameter */
-if (sscanf(param, "time=%s", buffer))
+if (Ustrncmp(param, "time=", 5) == 0)
{
unsigned int start_h = 0, start_m = 0, start_s = 0;
unsigned int end_h = 24, end_m = 0, end_s = 0;
unsigned int time_start, time_end;
- uschar *start_string;
- uschar *end_string;
- uschar *delimiter;
+ const uschar * end_string;
- if ((delimiter = US strchr(CS buffer, '-')))
+ s = param+5;
+ if ((end_string = Ustrchr(s, '-')))
{
- *delimiter = '\0';
- start_string = buffer;
- end_string = delimiter + 1;
- if (sscanf(CS end_string, "%u.%u.%u", &end_h, &end_m, &end_s) == 0 ||
- sscanf(CS start_string, "%u.%u.%u", &start_h, &start_m, &start_s) == 0)
+ end_string++;
+ if ( sscanf(CS end_string, "%u.%u.%u", &end_h, &end_m, &end_s) == 0
+ || sscanf(CS s, "%u.%u.%u", &start_h, &start_m, &start_s) == 0
+ )
{
log_write(0, LOG_MAIN,
- "%s warning - invalid spamd time value: '%s'", loglabel, buffer);
+ "%s warning - invalid spamd time value: '%s'", loglabel, s);
return -1; /* syntax error */
}
}
else
{
log_write(0, LOG_MAIN,
- "%s warning - invalid spamd time value: '%s'", loglabel, buffer);
+ "%s warning - invalid spamd time value: '%s'", loglabel, s);
return -1; /* syntax error */
}
return 0;
}
+if (Ustrncmp(param, "tmo=", 4) == 0)
+ {
+ int sec = readconf_readtime((s = param+4), '\0', FALSE);
+ if (sec < 0)
+ {
+ log_write(0, LOG_MAIN,
+ "%s warning - invalid spamd timeout value: '%s'", loglabel, s);
+ return -1; /* syntax error */
+ }
+ timeout_sec = sec;
+ return 0;
+ }
+
log_write(0, LOG_MAIN, "%s warning - invalid spamd parameter: '%s'",
loglabel, param);
return -1; /* syntax error */
(strcmpic(user_name,US"false") == 0) )
return FAIL;
+timeout_sec = SPAMD_TIMEOUT;
+
/* if there is an additional option, check if it is "true" */
if (strcmpic(list,US"true") == 0)
/* in that case, always return true later */
uschar *address;
uschar *spamd_address_list_ptr = spamd_address_work;
spamd_address_container * spamd_address_vector[32];
-
+ spamd_address_container * sd;
/* Check how many spamd servers we have
and register their addresses */
int sublist_sep = -(int)' '; /* default space-sep */
unsigned args;
uschar * s;
- spamd_address_container * this_spamd =
- (spamd_address_container *)store_get(sizeof(spamd_address_container));
HDEBUG(D_acl) debug_printf("spamd: addr entry '%s'\n", address);
+ sd = (spamd_address_container *)store_get(sizeof(spamd_address_container));
- for (sublist = address, args = 0, spamd_param_init(this_spamd);
+ for (sublist = address, args = 0, spamd_param_init(sd);
s = string_nextinlist(&sublist, &sublist_sep, NULL, 0);
args++
)
HDEBUG(D_acl) debug_printf("spamd: addr parm '%s'\n", s);
switch (args)
{
- case 0: this_spamd->hostname = s;
+ case 0: sd->hostspec = s;
if (*s == '/') args++; /* local; no port */
break;
- case 1: this_spamd->tcp_port = atoi(s); break;
- default: spamd_param(s, this_spamd); break;
+ case 1: sd->hostspec = string_sprintf("%s %s", sd->hostspec, s);
+ break;
+ default: spamd_param(s, sd);
+ break;
}
}
if (args < 2)
continue;
}
- spamd_address_vector[num_servers] = this_spamd;
+ spamd_address_vector[num_servers] = sd;
if (++num_servers > 31)
break;
}
log_write(0, LOG_MAIN|LOG_PANIC,
"%s no useable spamd server addresses in spamd_address configuration option.",
loglabel);
- (void)fclose(mbox_file);
- return DEFER;
+ goto defer;
}
while (1)
{
- struct hostent *he;
- int i;
- spamd_address_container * this_spamd;
- BOOL is_local;
+ uschar * errstr;
current_server = spamd_get_server(spamd_address_vector, num_servers);
- this_spamd = spamd_address_vector[current_server];
-
- is_local = *this_spamd->hostname == '/';
+ sd = spamd_address_vector[current_server];
- debug_printf(is_local
- ? "trying server %s\n" : "trying server %s, port %u\n",
- this_spamd->hostname, this_spamd->tcp_port);
+ debug_printf("trying server %s\n", sd->hostspec);
/* contact a spamd */
- if (is_local)
- {
- if ((spamd_sock = socket(AF_UNIX, SOCK_STREAM, 0)) < 0)
- {
- log_write(0, LOG_MAIN|LOG_PANIC,
- "%s spamd: unable to acquire socket (%s)",
- loglabel,
- strerror(errno));
- (void)fclose(mbox_file);
- return DEFER;
- }
-
- server.sun_family = AF_UNIX;
- Ustrcpy(server.sun_path, this_spamd->hostname);
+ if ((spamd_sock = ip_streamsocket(sd->hostspec, &errstr, 5)) >= 0)
+ break;
- if (connect(spamd_sock, (struct sockaddr *) &server, sizeof(struct sockaddr_un)) >= 0)
- {
- is_rspamd = this_spamd->is_rspamd;
- break; /* connection OK */
- }
+ log_write(0, LOG_MAIN, "%s spamd: %s", loglabel, errstr);
+ sd->is_failed = TRUE;
- log_write(0, LOG_MAIN|LOG_PANIC,
- "%s spamd: unable to connect to UNIX socket %s (%s)",
- loglabel, server.sun_path, strerror(errno) );
- }
- else
+ current_server = spamd_get_server(spamd_address_vector, num_servers);
+ if (current_server < 0)
{
- if ((spamd_sock = ip_socket(SOCK_STREAM, AF_INET)) < 0)
- {
- log_write(0, LOG_MAIN|LOG_PANIC,
- "%s error creating IP socket for spamd", loglabel);
- (void)fclose(mbox_file);
- return DEFER;
- }
-
- /*XXX should we use getaddrinfo? */
- if (!(he = gethostbyname(CS this_spamd->hostname)))
- log_write(0, LOG_MAIN|LOG_PANIC,
- "%s failed to lookup host '%s'", loglabel, this_spamd->hostname);
-
- else
- {
- struct in_addr in = *(struct in_addr *) he->h_addr_list[0];
-
- if (ip_connect(spamd_sock, AF_INET, US inet_ntoa(in),
- this_spamd->tcp_port, 5) > -1)
- {
- is_rspamd = this_spamd->is_rspamd;
- break; /* connection OK */
- }
-
- log_write(0, LOG_MAIN|LOG_PANIC,
- "%s warning - spamd connection to '%s', port %u failed: %s",
- loglabel,
- this_spamd->hostname, this_spamd->tcp_port, strerror(errno));
- }
-
- (void)close(spamd_sock);
-
- this_spamd->is_failed = TRUE;
- current_server = spamd_get_server(spamd_address_vector, num_servers);
- if (current_server < 0)
- {
- log_write(0, LOG_MAIN|LOG_PANIC, "%s all spamd servers failed",
- loglabel);
- (void)fclose(mbox_file);
- return DEFER;
- }
+ log_write(0, LOG_MAIN|LOG_PANIC, "%s all spamd servers failed",
+ loglabel);
+ goto defer;
}
}
+ is_rspamd = sd->is_rspamd;
}
if (spamd_sock == -1)
{
log_write(0, LOG_MAIN|LOG_PANIC,
"programming fault, spamd_sock unexpectedly unset");
- (void)fclose(mbox_file);
- return DEFER;
+ goto defer;
}
(void)fcntl(spamd_sock, F_SETFL, O_NONBLOCK);
(void)close(spamd_sock);
log_write(0, LOG_MAIN|LOG_PANIC,
"%s spamd send failed: %s", loglabel, strerror(errno));
- (void)fclose(mbox_file);
- return DEFER;
+ goto defer;
}
/* now send the file */
"%s %s on spamd socket", loglabel, strerror(errno));
else
{
- if (time(NULL) - start < SPAMD_TIMEOUT)
+ if (time(NULL) - start < timeout_sec)
goto again;
log_write(0, LOG_MAIN|LOG_PANIC,
"%s timed out writing spamd socket", loglabel);
}
(void)close(spamd_sock);
- (void)fclose(mbox_file);
- return DEFER;
+ goto defer;
}
wrote = send(spamd_sock,spamd_buffer + offset,read - offset,0);
log_write(0, LOG_MAIN|LOG_PANIC,
"%s %s on spamd socket", loglabel, strerror(errno));
(void)close(spamd_sock);
- (void)fclose(mbox_file);
- return DEFER;
+ goto defer;
}
if (offset + wrote != read)
{
log_write(0, LOG_MAIN|LOG_PANIC,
"%s error reading spool file: %s", loglabel, strerror(errno));
(void)close(spamd_sock);
- (void)fclose(mbox_file);
- return DEFER;
+ goto defer;
}
(void)fclose(mbox_file);
while ((i = ip_recv(spamd_sock,
spamd_buffer + offset,
sizeof(spamd_buffer) - offset - 1,
- SPAMD_TIMEOUT - time(NULL) + start)) > 0 )
+ timeout_sec - time(NULL) + start)) > 0 )
offset += i;
/* error handling */
return override
? OK /* always return OK, no matter what the score */
: spam_rc;
+
+defer:
+ (void)fclose(mbox_file);
+ return DEFER;
}
#endif
+/* vi: aw ai sw=2
+*/
git://git.exim.org / exim.git / blobdiff