CVE-2020-28024: Heap buffer underflow in smtp_ungetc()

[exim.git] / src / src / perl.c

diff --git a/src/src/perl.c b/src/src/perl.c
index 92218a6efb1e5d33ba9c5289dc53a9b7e9337a03..58643f0fa24707009068a5e361b4d4f94ddb33be 100644 (file)
--- a/src/src/perl.c
+++ b/src/src/perl.c
@@ -3,6 +3,7 @@
 *************************************************/
 
 /* Copyright (c) 1998 Malcolm Beattie */
 *************************************************/
 
 /* Copyright (c) 1998 Malcolm Beattie */

+/* Copyright (C) 1999 - 2018  Exim maintainers */

 
 /* Modified by PH to get rid of the "na" usage, March 1999.
    Modified further by PH for general tidying for Exim 4.
 
 /* Modified by PH to get rid of the "na" usage, March 1999.
    Modified further by PH for general tidying for Exim 4.


@@ -60,8 +61,8 @@ XS(xs_expand_string)
   str = expand_string(US SvPV(ST(0), len));
   ST(0) = sv_newmortal();
   if (str != NULL)
   str = expand_string(US SvPV(ST(0), len));
   ST(0) = sv_newmortal();
   if (str != NULL)

-    sv_setpv(ST(0), (const char *) str);
-  else if (!expand_string_forcedfail)
+    sv_setpv(ST(0), CCS  str);
+  else if (!f.expand_string_forcedfail)

     croak("syntax error in Exim::expand_string argument: %s",
       expand_string_message);
 }
     croak("syntax error in Exim::expand_string argument: %s",
       expand_string_message);
 }


@@ -150,9 +151,8 @@ cleanup_perl(void)
   interp_perl = 0;
 }
 
   interp_perl = 0;
 }
 

-uschar *
-call_perl_cat(uschar *yield, int *sizep, int *ptrp, uschar **errstrp,
-  uschar *name, uschar **arg)
+gstring *
+call_perl_cat(gstring * yield, uschar **errstrp, uschar *name, uschar **arg)

 {
   dSP;
   SV *sv;
 {
   dSP;
   SV *sv;


@@ -186,7 +186,7 @@ call_perl_cat(uschar *yield, int *sizep, int *ptrp, uschar **errstrp,
     return NULL;
     }
   str = US SvPV(sv, len);
     return NULL;
     }
   str = US SvPV(sv, len);

-  yield = string_catn(yield, sizep, ptrp, str, (int)len);
+  yield = string_catn(yield, str, (int)len);

   FREETMPS;
   LEAVE;
 
   FREETMPS;
   LEAVE;