git://git.exim.org
/
exim.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
tidying
[exim.git]
/
src
/
src
/
lookups
/
pgsql.c
diff --git
a/src/src/lookups/pgsql.c
b/src/src/lookups/pgsql.c
index c121cb66810cc1473277e677f6a4fe1a35da9781..1583378d548eb9ca0f6ebb1e342bb9921f0ea303 100644
(file)
--- a/
src/src/lookups/pgsql.c
+++ b/
src/src/lookups/pgsql.c
@@
-2,9
+2,10
@@
* Exim - an Internet mail transport agent *
*************************************************/
* Exim - an Internet mail transport agent *
*************************************************/
+/* Copyright (c) The Exim Maintainers 2020 - 2022 */
/* Copyright (c) University of Cambridge 1995 - 2018 */
/* Copyright (c) University of Cambridge 1995 - 2018 */
-/* Copyright (c) The Exim Maintainers 2020 */
/* See the file NOTICE for conditions of use and distribution. */
/* See the file NOTICE for conditions of use and distribution. */
+/* SPDX-License-Identifier: GPL-2.0-or-later */
/* Thanks to Petr Cech for contributing the original code for these
functions. Thanks to Joachim Wieland for the initial patch for the Unix domain
/* Thanks to Petr Cech for contributing the original code for these
functions. Thanks to Joachim Wieland for the initial patch for the Unix domain
@@
-262,7
+263,7
@@
if (!cn)
/* Add the connection to the cache */
/* Add the connection to the cache */
- cn = store_get(sizeof(pgsql_connection),
FALSE
);
+ cn = store_get(sizeof(pgsql_connection),
GET_UNTAINTED
);
cn->server = server_copy;
cn->handle = pg_conn;
cn->next = pgsql_connections;
cn->server = server_copy;
cn->handle = pg_conn;
cn->next = pgsql_connections;
@@
-336,6
+337,7
@@
for (int i = 0; i < num_tuples; i++)
uschar *tmp = US PQgetvalue(pg_result, i, j);
result = lf_quote(US PQfname(pg_result, j), tmp, Ustrlen(tmp), result);
}
uschar *tmp = US PQgetvalue(pg_result, i, j);
result = lf_quote(US PQfname(pg_result, j), tmp, Ustrlen(tmp), result);
}
+ if (!result) result = string_get(1);
}
/* If result is NULL then no data has been found and so we return FAIL. */
}
/* If result is NULL then no data has been found and so we return FAIL. */
@@
-413,12
+415,13
@@
Why, I don't know. Seems odd for just string escaping...]
Arguments:
s the string to be quoted
opt additional option text or NULL if none
Arguments:
s the string to be quoted
opt additional option text or NULL if none
+ idx lookup type index
Returns: the processed string or NULL for a bad option
*/
static uschar *
Returns: the processed string or NULL for a bad option
*/
static uschar *
-pgsql_quote(uschar * s, uschar * opt)
+pgsql_quote(uschar * s, uschar * opt
, unsigned idx
)
{
int count = 0, c;
uschar * t = s, * quoted;
{
int count = 0, c;
uschar * t = s, * quoted;
@@
-428,8
+431,7
@@
if (opt) return NULL; /* No options recognized */
while ((c = *t++))
if (Ustrchr("\n\t\r\b\'\"\\", c) != NULL) count++;
while ((c = *t++))
if (Ustrchr("\n\t\r\b\'\"\\", c) != NULL) count++;
-if (count == 0) return s;
-t = quoted = store_get(Ustrlen(s) + count + 1, is_tainted(s));
+t = quoted = store_get_quoted(Ustrlen(s) + count + 1, s, idx);
while ((c = *s++))
{
while ((c = *s++))
{
@@
-466,11
+468,11
@@
return quoted;
#include "../version.h"
#include "../version.h"
-void
-pgsql_version_report(
FILE *f
)
+gstring *
+pgsql_version_report(
gstring * g
)
{
#ifdef DYNLOOKUP
{
#ifdef DYNLOOKUP
-
fprintf(f
, "Library version: PostgreSQL: Exim version %s\n", EXIM_VERSION_STR);
+
g = string_fmt_append(g
, "Library version: PostgreSQL: Exim version %s\n", EXIM_VERSION_STR);
#endif
/* Version reporting: there appears to be no available information about
#endif
/* Version reporting: there appears to be no available information about
@@
-478,6
+480,8
@@
the client library in libpq-fe.h; once you have a connection object, you
can access the server version and the chosen protocol version, but those
aren't really what we want. It might make sense to debug_printf those
when the connection is established though? */
can access the server version and the chosen protocol version, but those
aren't really what we want. It might make sense to debug_printf those
when the connection is established though? */
+
+return g;
}
}