Tidying: coverity issues

[exim.git] / src / src / parse.c

diff --git a/src/src/parse.c b/src/src/parse.c
index 7a072558afc08c8a39739417808f3bec5e8ecbe8..9b7069f9efb36c617f6ba9ec65809014186ec8b9 100644 (file)
--- a/src/src/parse.c
+++ b/src/src/parse.c
@@ -1460,15 +1460,16 @@ for (;;)
        temp = *p;
        *p = '\0';
 
-       if ((fd2 = openat(fd, q, O_RDONLY|O_NOFOLLOW)) < 0)
+       fd2 = openat(fd, q, O_RDONLY|O_NOFOLLOW);
+       close(fd);
+       *p = temp;
+       if (fd2 < 0)
          {
           *error = string_sprintf("failed to open %s (component of included "
             "file); could be symbolic link", filename);
          return FF_ERROR;
          }
-       close(fd);
        fd = fd2;
-       *p = temp;
        }
       f = fdopen(fd, "rb");
       }