{
int fd;
const uschar * where;
-struct sockaddr_un sun = {.sun_family = AF_UNIX};
+struct sockaddr_un sa_un = {.sun_family = AF_UNIX};
int len;
DEBUG(D_any) debug_printf("creating notifier socket ");
-where = US"socket";
#ifdef SOCK_CLOEXEC
if ((fd = socket(PF_UNIX, SOCK_DGRAM|SOCK_CLOEXEC, 0)) < 0)
- goto bad;
+ { where = US"socket"; goto bad; }
#else
-if ((fd = socket(AF_UNIX, SOCK_DGRAM, 0)) < 0)
- goto bad;
+if ((fd = socket(PF_UNIX, SOCK_DGRAM, 0)) < 0)
+ { where = US"socket"; goto bad; }
(void)fcntl(fd, F_SETFD, fcntl(fd, F_GETFD) | FD_CLOEXEC);
#endif
#ifdef EXIM_HAVE_ABSTRACT_UNIX_SOCKETS
-sun.sun_path[0] = 0; /* Abstract local socket addr - Linux-specific? */
+sa_un.sun_path[0] = 0; /* Abstract local socket addr - Linux-specific? */
len = offsetof(struct sockaddr_un, sun_path) + 1
- + snprintf(sun.sun_path+1, sizeof(sun.sun_path)-1, "%s", NOTIFIER_SOCKET_NAME);
-DEBUG(D_any) debug_printf("@%s\n", sun.sun_path+1);
+ + snprintf(sa_un.sun_path+1, sizeof(sa_un.sun_path)-1, "%s", NOTIFIER_SOCKET_NAME);
+DEBUG(D_any) debug_printf("@%s\n", sa_un.sun_path+1);
#else /* filesystem-visible and persistent; will neeed removal */
len = offsetof(struct sockaddr_un, sun_path)
- + snprintf(sun.sun_path, sizeof(sun.sun_path), "%s/%s",
+ + snprintf(sa_un.sun_path, sizeof(sa_un.sun_path), "%s/%s",
spool_directory, NOTIFIER_SOCKET_NAME);
-DEBUG(D_any) debug_printf("%s\n", sun.sun_path);
+DEBUG(D_any) debug_printf("%s\n", sa_un.sun_path);
#endif
-where = US"bind";
-if (bind(fd, (const struct sockaddr *)&sun, len) < 0)
- goto bad;
+if (bind(fd, (const struct sockaddr *)&sa_un, len) < 0)
+ { where = US"bind"; goto bad; }
#ifdef SO_PASSCRED /* Linux */
-where = US"SO_PASSCRED";
if (setsockopt(fd, SOL_SOCKET, SO_PASSCRED, &on, sizeof(on)) < 0)
- goto bad;
+ { where = US"SO_PASSCRED"; goto bad2; }
#elif defined(LOCAL_CREDS) /* FreeBSD-ish */
-where = US"LOCAL_CREDS";
-if (setsockopt(fd, SOL_SOCKET, LOCAL_CREDS, &on, sizeof(on)) < 0)
- goto bad;
+if (setsockopt(fd, 0, LOCAL_CREDS, &on, sizeof(on)) < 0)
+ { where = US"LOCAL_CREDS"; goto bad2; }
#endif
/* debug_printf("%s: fd %d\n", __FUNCTION__, fd); */
daemon_notifier_fd = fd;
return;
+bad2:
+#ifndef EXIM_HAVE_ABSTRACT_UNIX_SOCKETS
+ Uunlink(sa_un.sun_path);
+#endif
bad:
- log_write(0, LOG_MAIN|LOG_PANIC, "%s: %s: %s",
+ log_write(0, LOG_MAIN|LOG_PANIC, "%s %s: %s",
__FUNCTION__, where, strerror(errno));
+ close(fd);
+ return;
}
daemon_notification(void)
{
uschar buf[256], cbuf[256];
-struct sockaddr_un sun;
+struct sockaddr_un sa_un;
struct iovec iov = {.iov_base = buf, .iov_len = sizeof(buf)-1};
-struct msghdr msg = { .msg_name = &sun,
- .msg_namelen = sizeof(sun),
+struct msghdr msg = { .msg_name = &sa_un,
+ .msg_namelen = sizeof(sa_un),
.msg_iov = &iov,
.msg_iovlen = 1,
.msg_control = cbuf,
debug_printf("addrlen %d\n", msg.msg_namelen);
#endif
DEBUG(D_queue_run) debug_printf("%s from addr '%s%.*s'\n", __FUNCTION__,
- *sun.sun_path ? "" : "@",
- (int)msg.msg_namelen - (*sun.sun_path ? 0 : 1),
- sun.sun_path + (*sun.sun_path ? 0 : 1));
+ *sa_un.sun_path ? "" : "@",
+ (int)msg.msg_namelen - (*sa_un.sun_path ? 0 : 1),
+ sa_un.sun_path + (*sa_un.sun_path ? 0 : 1));
/* Refuse to handle the item unless the peer has good credentials */
#ifdef SCM_CREDENTIALS
debug_printf("%s: queue size request: %s\n", __FUNCTION__, buf);
if (sendto(daemon_notifier_fd, buf, len, 0,
- (const struct sockaddr *)&sun, msg.msg_namelen) < 0)
+ (const struct sockaddr *)&sa_un, msg.msg_namelen) < 0)
log_write(0, LOG_MAIN|LOG_PANIC,
"%s: sendto: %s\n", __FUNCTION__, strerror(errno));
return FALSE;