From: Philip Hazel <ph10@hermes.cam.ac.uk>
Date: Tue, 13 Mar 2007 09:59:07 +0000 (+0000)
Subject: Change HDA_SIZE in oracle.c from 256 to 512. This is needed for 64-bit
X-Git-Tag: exim-4_67~22
X-Git-Url: https://git.exim.org/users/jgh/exim.git/commitdiff_plain/dee5a20ae91f94693553e63bbbd83160652aafb0?ds=sidebyside

Change HDA_SIZE in oracle.c from 256 to 512. This is needed for 64-bit
cpus.
---

diff --git a/doc/doc-txt/ChangeLog b/doc/doc-txt/ChangeLog
index 55a1aaa4c..eb3ce2b9b 100644
--- a/doc/doc-txt/ChangeLog
+++ b/doc/doc-txt/ChangeLog
@@ -1,4 +1,4 @@
-$Cambridge: exim/doc/doc-txt/ChangeLog,v 1.488 2007/03/13 09:50:22 ph10 Exp $
+$Cambridge: exim/doc/doc-txt/ChangeLog,v 1.489 2007/03/13 09:59:07 ph10 Exp $
 
 Change log file for Exim from version 4.21
 -------------------------------------------
@@ -149,6 +149,9 @@ PH/33 Compile failed with OpenSSL 0.9.8e. This was due to a coding error in
       changed to a proper function call with a void return, hence the compile
       error. Exim's code has been fixed.
 
+PH/34 Change HDA_SIZE in oracle.c from 256 to 512. This is needed for 64-bit
+      cpus.
+
 
 Exim version 4.66
 -----------------
diff --git a/src/src/lookups/oracle.c b/src/src/lookups/oracle.c
index eb83e71c7..77084e403 100644
--- a/src/src/lookups/oracle.c
+++ b/src/src/lookups/oracle.c
@@ -1,4 +1,4 @@
-/* $Cambridge: exim/src/src/lookups/oracle.c,v 1.4 2007/01/08 10:50:19 ph10 Exp $ */
+/* $Cambridge: exim/src/src/lookups/oracle.c,v 1.5 2007/03/13 09:59:07 ph10 Exp $ */
 
 /*************************************************
 *     Exim - an Internet mail transport agent    *
@@ -42,9 +42,14 @@ static void dummy(int x) { dummy(x-1); }
 #define MAX_SELECT_LIST_SIZE    32     /* maximum number of columns (not rows!) */
 
 /* Paul's comment on this was "change this to 512 for 64bit cpu", but I don't
-understand why. The Oracle manual just asks for 256 bytes. */
+understand why. The Oracle manual just asks for 256 bytes.
 
-#define HDA_SIZE 256
+That was years ago. Jin Choi suggested (March 2007) that this change should
+be made in the source, as at worst it wastes 256 bytes, and it saves people
+having to discover about this for themselves as more and more systems are
+64-bit. So I have changed 256 to 512. */
+
+#define HDA_SIZE 512
 
 /* Internal/external datatype codes */