From: Jeremy Harris <jgh146exb@wizmail.org>
Date: Sun, 29 Sep 2019 11:49:34 +0000 (+0100)
Subject: DKIM: fix errorcheck in signing, lilbgcrypt version.  Bug 2450
X-Git-Url: https://git.exim.org/users/jgh/exim.git/commitdiff_plain/428cdca73df1791fcba048d0f1093725d8288bd6?hp=bb71a66f55c3dd047dd5973c08365a967910f5e1

DKIM: fix errorcheck in signing, lilbgcrypt version.  Bug 2450
---

diff --git a/src/src/pdkim/signing.c b/src/src/pdkim/signing.c
index aff3d9061..102e7bf51 100644
--- a/src/src/pdkim/signing.c
+++ b/src/src/pdkim/signing.c
@@ -412,8 +412,9 @@ if (  !(s1 = Ustrstr(CS privkey_pem, "-----BEGIN RSA PRIVATE KEY-----"))
 
 *s2 = '\0';
 
-if ((der.len = b64decode(s1, &der.data)) < 0)
+if ((rc = b64decode(s1, &der.data) < 0))
   return US"Bad PEM-DER b64 decode";
+der.len = rc;
 
 /* untangle asn.1 */