X-Git-Url: https://git.exim.org/users/jgh/exim.git/blobdiff_plain/5d03669979a0faed6caec3d32f7caac9321eb160..e5de15b6291e882cf936f384b87a0d5d368d1caa:/doc/doc-txt/ChangeLog?ds=sidebyside diff --git a/doc/doc-txt/ChangeLog b/doc/doc-txt/ChangeLog index 8ef8b0b6c..00377b9ff 100644 --- a/doc/doc-txt/ChangeLog +++ b/doc/doc-txt/ChangeLog @@ -1,15 +1,204 @@ Change log file for Exim from version 4.21 -------------------------------------------- +------------------------------------------ This document describes *changes* to previous versions, that might affect Exim's operation, with an unchanged configuration file. For new options, and new features, see the NewStuff file next to this ChangeLog. +Exim version 4.90 +----------------- + +JH/01 Rework error string handling in TLS interface so that the caller in + more cases is responsible for logging. This permits library-sourced + string to be attached to addresses during delivery, and collapses + pairs of long lines into single ones. + +PP/01 Allow PKG_CONFIG_PATH to be set in Local/Makefile and use it correctly + during configuration. Wildcards are allowed and expanded. + +JH/02 Rework error string handling in DKIM to pass more info back to callers. + This permits better logging. + +JH/03 Rework the transport continued-connection mechanism: when TLS is active, + do not close it down and have the child transport start it up again on + the passed-on TCP connection. Instead, proxy the child (and any + subsequent ones) for TLS via a unix-domain socket channel. Logging is + affected: the continued delivery log lines do not have any DNSSEC, TLS + Certificate or OCSP information. TLS cipher information is still logged. + +JH/04 Shorten the log line for daemon startup by collapsing adjacent sets of + identical IP addresses on different listening ports. Will also affect + "exiwhat" output. + +PP/02 Bug 2070: uClibc defines __GLIBC__ without providing glibc headers; + add noisy ifdef guards to special-case this sillyness. + Patch from Bernd Kuhls. + +JH/05 Tighten up the checking in isip4 (et al): dotted-quad components larger + than 255 are no longer allowed. + +JH/06 Default openssl_options to include +no_ticket, to reduce load on peers. + Disable the session-cache too, which might reduce our load. Since we + currrectly use a new context for every connection, both as server and + client, there is no benefit for these. + GnuTLS appears to not support tickets server-side by default (we don't + call gnutls_session_ticket_enable_server()) but client side is enabled + by default on recent versions (3.1.3 +) unless the PFS priority string + is used (3.2.4 +). + +PP/03 Add $SOURCE_DATE_EPOCH support for reproducible builds, per spec at + . + +JH/07 Fix smtp transport use of limited max_rcpt under mua_wrapper. Previously + the check for any unsuccessful recipients did not notice the limit, and + erroneously found still-pending ones. + +JH/08 Pipeline CHUNKING command and data together, on kernels that support + MSG_MORE. Only in-clear (not on TLS connections). + +JH/09 Avoid using a temporary file during transport using dkim. Unless a + transport-filter is involved we can buffer the headers in memory for + creating the signature, and read the spool data file once for the + signature and again for transmission. + +JH/10 Enable use of sendfile in Linux builds as default. It was disabled in + 4.77 as the kernel support then wasn't solid, having issues in 64bit + mode. Now, it's been long enough. Add support for FreeBSD also. + +JH/11 Bug 2104: Fix continued use of a transport connection with TLS. In the + case where the routing stage had gathered several addresses to send to + a host before calling the transport for the first, we previously failed + to close down TLS in the old transport process before passing the TCP + connection to the new process. The new one sent a STARTTLS command + which naturally failed, giving a failed delivery and bloating the retry + database. Investigation and fix prototype from Wolfgang Breyha. + +JH/12 Fix check on SMTP command input synchronisation. Previously there were + false-negatives in the check that the sender had not preempted a response + or prompt from Exim (running as a server), due to that code's lack of + awareness of the SMTP input buffering. + +PP/04 Add commandline_checks_require_admin option. + Exim drops privileges sanely, various checks such as -be aren't a + security problem, as long as you trust local users with access to their + own account. When invoked by services which pass untrusted data to + Exim, this might be an issue. Set this option in main configuration + AND make fixes to the calling application, such as using `--` to stop + processing options. + +JH/13 Do pipelining under TLS. Previously, although safe, no advantage was + taken. Now take care to pack both (client) MAIL,RCPT,DATA, and (server) + responses to those, into a single TLS record each way (this usually means + a single packet). As a side issue, smtp_enforce_sync now works on TLS + connections. + +PP/05 OpenSSL/1.1: use DH_bits() for more accurate DH param sizes. This + affects you only if you're dancing at the edge of the param size limits. + If you are, and this message makes sense to you, then: raise the + configured limit or use OpenSSL 1.1. Nothing we can do for older + versions. + +JH/14 For the "sock" variant of the malware scanner interface, accept an empty + cmdline element to get the documented default one. Previously it was + inaccessible. + +JH/15 Fix a crash in the smtp transport caused when two hosts in succession + are unsuable for non-message-specific reasons - eg. connection timeout, + banner-time rejection. + +JH/16 Fix logging of delivery remote port, when specified by router, under + callout/hold. + +PP/06 Repair manualroute's ability to take options in any order, even if one + is the name of a transport. + Fixes bug 2140. + +HS/01 Cleanup, prevent repeated use of -p/-oMr (CVE-2017-1000369) + +JH/17 Change the list-building routines interface to use the expanding-string + triplet model, for better allocation and copying behaviour. + +JH/18 Prebuild the data-structure for "builtin" macros, for faster startup. + Previously it was constructed the first time a possibly-matching string + was met in the configuration file input during startup; now it is done + during compilation. + +JH/19 Bug 2141: Use the full-complex API for Berkeley DB rather than the legacy- + compatible one, to avoid the (poorly documented) possibility of a config + file in the working directory redirecting the DB files, possibly correpting + some existing file. CVE-2017-10140 assigned for BDB. + +JH/20 Bug 2147: Do not defer for a verify-with-callout-and-random which is not + cache-hot. Previously, although the result was properly cached, the + initial verify call returned a defer. + +JH/21 Bug 2151: Avoid using SIZE on the MAIL for a callout verify, on any but + the main verify for receipient in uncached-mode. + +JH/22 Retire historical build files to an "unsupported" subdir. These are + defined as "ones for which we have no current evidence of testing". + +JH/23 DKIM: enforce the DNS pubkey record "h" permitted-hashes optional field, + if present. Previously it was ignored. + +JH/24 Start using specified-initialisers in C structure init coding. This is + a C99 feature (it's 2017, so now considered safe). + +JH/25 Use one-bit bitfields for flags in the "addr" data structure. Previously + if was a fixed-sized field and bitmask ops via macros; it is now more + extensible. + +PP/07 GitHub PR 56: Apply MariaDB build fix. + Patch provided by Jaroslav Å karvada. + +PP/08 Bug 2161: Fix regression in sieve quoted-printable handling introduced + during Coverity cleanups [4.87 JH/47] + Diagnosis and fix provided by Michael Fischer v. Mollard. + +JH/26 Fix DKIM bug: when the pseudoheader generated for signing was exactly + the right size to place the terminating semicolon on its own folded + line, the header hash was calculated to an incorrect value thanks to + the (relaxed) space the fold became. + +HS/02 Fix Bug 2130: large writes from the transport subprocess where chunked + and confused the parent. + +JH/27 Fix SOCKS bug: an unitialized pointer was deref'd by the transport process + which could crash as a result. This could lead to undeliverable messages. + +JH/28 Logging: "next input sent too soon" now shows where input was truncated + for log purposes. + +JH/29 Fix queue_run_in_order to ignore the PID portion of the message ID. This + matters on fast-turnover and PID-randomising systems, which were getting + out-of-order delivery. + +JH/30 Fix a logging bug on aarch64: an unsafe routine was previously used for + a possibly-overlapping copy. The symptom was that "Remote host closed + connection in response to HELO" was logged instead of the actual 4xx + error for the HELO. + +JH/31 Fix CHUNKING code to properly flush the unwanted chunk after an error. + Previously only that bufferd was discarded, resulting in SYMTP command + desynchronisation. + +JH/32 DKIM: when a message has multiple signatures matching an identity given + in dkim_verify_signers, run the dkim acl once for each. Previously only + one run was done. Bug 2189. + +JH/33 Downgrade an unfound-list name (usually a typo in the config file) from + "panic the current process" to "deliberately defer". The panic log is + still written with the problem list name; the mail and reject logs now + get a temp-reject line for the message that was being handled, saying + something like "domains check lookup or other defer". The SMTP 451 + message is still "Temporary local problem". + + Exim version 4.89 -------------------- +----------------- JH/01 Bug 1922: Support IDNA2008. This has slightly different conversion rules - than -2003 did; needs libidn2 in addition to linidn. + than -2003 did; needs libidn2 in addition to libidn. JH/02 The path option on a pipe transport is now expanded before use. @@ -19,6 +208,100 @@ PP/01 GitHub PR 50: Do not call ldap_start_tls_s on ldapi:// connections. JH/03 Bug 2003: fix Proxy Protocol v2 handling: the address size field was missing a wire-to-host endian conversion. +JH/04 Bug 2004: fix CHUNKING in non-PIPELINEING mode. Chunk data following + close after a BDAT command line could be taken as a following command, + giving a synch failure. Fix by only checking for synch immediately + before acknowledging the chunk. + +PP/02 GitHub PR 52: many spelling fixes, which include fixing parsing of + no_require_dnssec option and creation of _HAVE_TRANSPORT_APPEND_MAILDIR + macro. Patches provided by Josh Soref. + +JH/05 Have the EHLO response advertise VRFY, if there is a vrfy ACL defined. + Previously we did not; the RFC seems ambiguous and VRFY is not listed + by IANA as a service extension. However, John Klensin suggests that we + should. + +JH/06 Bug 2017: Fix DKIM verification in -bh test mode. The data feed into + the dkim code may be unix-mode line endings rather than smtp wire-format + CRLF, so prepend a CR to any bare LF. + +JH/07 Rationalise the coding for callout smtp conversations and transport ones. + As a side-benfit, callouts can now use PIPELINING hence fewer round-trips. + +JH/08 Bug 2016: Fix DKIM verification vs. CHUNKING. Any BDAT commands after + the first were themselves being wrongly included in the feed into dkim + processing; with most chunk sizes in use this resulted in an incorrect + body hash calculated value. + +JH/09 Bug 2014: permit inclusion of a DKIM-Signature header in a received + DKIM signature block, for verification. Although advised against by + standards it is specifically not ruled illegal. + +JH/10 Bug 2025: Fix reception of (quoted) local-parts with embedded spaces. + +JH/11 Bug 2029: Fix crash in DKIM verification when a message signature block is + missing a body hash (the bh= tag). + +JH/12 Bug 2018: Re-order Proxy Protocol startup versus TLS-on-connect startup. + It seems that HAProxy sends the Proxy Protocol information in clear and + only then does a TLS startup, so do the same. + +JH/13 Bug 2027: Avoid attempting to use TCP Fast Open for non-transport client + TCP connections (such as for Spamd) unless the daemon successfully set + Fast Open mode on its listening sockets. This fixes breakage seen on + too-old kernels or those not configured for Fast Open, at the cost of + requiring both directions being enabled for TFO, and TFO never being used + by non-daemon-related Exim processes. + +JH/14 Bug 2000: Reject messages recieved with CHUNKING but with malformed line + endings, at least on the first header line. Try to canonify any that get + past that check, despite the cost. + +JH/15 Angle-bracket nesting (an error inserted by broken sendmails) levels are + now limited to an arbitrary five deep, while parsing addresses with the + strip_excess_angle_brackets option enabled. + +PP/03 Bug 2018: For Proxy Protocol and TLS-on-connect, do not over-read and + instead leave the unprompted TLS handshake in socket buffer for the + TLS library to consume. + +PP/04 Bug 2018: Also handle Proxy Protocol v2 safely. + +PP/05 FreeBSD compat: handle that Ports no longer create /usr/bin/perl + +JH/16 Drop variables when they go out of scope. Memory management drops a whole + region in one operation, for speed, and this leaves assigned pointers + dangling. Add checks run only under the testsuite which checks all + variables at a store-reset and panics on a dangling pointer; add code + explicitly nulling out all the variables discovered. Fixes one known + bug: a transport crash, where a dangling pointer for $sending_ip_address + originally assigned in a verify callout, is re-used. + +PP/06 Drop '.' from @INC in various Perl scripts. + +PP/07 Switch FreeBSD iconv to always use the base-system libc functions. + +PP/08 Reduce a number of compilation warnings under clang; building with + CC=clang CFLAGS+=-Wno-dangling-else -Wno-logical-op-parentheses + should be warning-free. + +JH/17 Fix inbound CHUNKING when DKIM disabled at runtime. + +HS/01 Fix portability problems introduced by PP/08 for platforms where + realloc(NULL) is not equivalent to malloc() [SunOS et al]. + +HS/02 Bug 1974: Fix missing line terminator on the last received BDAT + chunk. This allows us to accept broken chunked messages. We need a more + general solution here. + +PP/09 Wrote util/chunking_fixqueue_finalnewlines.pl to help recover + already-broken messages in the queue. + +JH/18 Bug 2061: Fix ${extract } corrupting an enclosing ${reduce } $value. + +JH/19 Fix reference counting bug in routing-generated-address tracking. + Exim version 4.88 ----------------- @@ -85,7 +368,7 @@ JH/16 DANE: treat a TLSA lookup response having all non-TLSA RRs, the same as one having no matching records. Previously we deferred the message that needed the lookup. -JH/17 Fakereject: previously logged as a norml message arrival "<="; now +JH/17 Fakereject: previously logged as a normal message arrival "<="; now distinguished as "(=". JH/18 Bug 1867: make the fail_defer_domains option on a dnslookup router work @@ -96,7 +379,7 @@ JH/19 Bug 1850: support Radius libraries that return REJECT_RC. JH/20 Bug 1872: Ensure that acl_smtp_notquit is run when the connection drops after the data-go-ahead and data-ack. Patch from Jason Betts. -JH/21 Bug 1846: Send DMARC forensic reports for reject and quaratine results, +JH/21 Bug 1846: Send DMARC forensic reports for reject and quarantine results, even for a "none" policy. Patch from Tony Meyer. JH/22 Fix continued use of a connection for further deliveries. If a port was @@ -209,7 +492,7 @@ JH/05 Downgrade message for a TLS-certificate-based authentication fail from HS/02 Add the Exim version string to the process info. This way exiwhat gives some more detail about the running daemon. -JH/06 Bug 1395: time-limit cacheing of DNS lookups, to the TTL value. This may +JH/06 Bug 1395: time-limit caching of DNS lookups, to the TTL value. This may matter for fast-change records such as DNSBLs. JH/07 Bug 1678: Always record an interface option value, if set, as part of a @@ -243,7 +526,7 @@ JH/17 Bug 1713: Fix non-PDKIM_DEBUG build. Patch from Jasen Betts. JH/18 Bug 1709: When built with TLS support, the tls_advertise_hosts option now defaults to "*" (all hosts). The variable is now available when not built - with TLS, default unset, mainly to enable keeping the testuite sane. + with TLS, default unset, mainly to enable keeping the testsuite sane. If a server certificate is not supplied (via tls_certificate) an error is logged, and clients will find TLS connections fail on startup. Presumably they will retry in-clear. @@ -257,7 +540,7 @@ JH/19 Two additional event types: msg:rcpt:defer and msg:rcpt:host:defer. Both in transport context, after the attempt, and per-recipient. The latter type is per host attempted. The event data is the error message, and the errno information encodes the lookup type (A vs. MX) used for the (first) host, - and the trailing two digits of the smtp 4xx reponse. + and the trailing two digits of the smtp 4xx response. GF/01 Bug 1715: Fix for race condition in exicyclog, where exim could attempt to write to mainlog (or rejectlog, paniclog) in the window between file @@ -272,7 +555,7 @@ JH/21 Bug 1720: Add support for priority groups and weighted-random proxy "pri" and "weight". Note that the previous implicit priority given by the list order is no longer honoured. -JH/22 Bugs 963, 1721: Fix some corner cases in message body canonicalisation +JH/22 Bugs 963, 1721: Fix some corner cases in message body canonicalization for DKIM processing. JH/23 Move SOCKS5 support from Experimental to mainline, enabled for a build @@ -454,13 +737,13 @@ JH/25 Bug 466: Add RFC2322 support for MIME attachment filenames. HS/02 Bug 1575: exigrep falls back to autodetection of compressed files if ZCAT_COMMAND is not executable. -JH/26 Bug 1539: Add timout/retry options on dnsdb lookups. +JH/26 Bug 1539: Add timeout/retry options on dnsdb lookups. JH/27 Bug 286: Support SOA lookup in dnsdb lookups. JH/28 Bug 1588: Do not use the A lookup following an AAAA for setting the FQDN. Normally benign, it bites when the pair was led to by a CNAME; - modern usage is to not canoicalize the domain to a CNAME target + modern usage is to not canonicalize the domain to a CNAME target (and we were inconsistent anyway for A-only vs AAAA+A). JH/29 Bug 1632: Removed the word "rejected" from line logged for ACL discards. @@ -526,7 +809,7 @@ JH/05 Fix results-pipe from transport process. Several recipients, combined with certificate use, exposed issues where response data items split over buffer boundaries were not parsed properly. This eventually resulted in duplicates being sent. This issue only became common enough - to notice due to the introduction of conection certificate information, + to notice due to the introduction of connection certificate information, the item size being so much larger. Found and fixed by Wolfgang Breyha. JH/06 Bug 1533: Fix truncation of items in headers_remove lists. A fixed @@ -536,7 +819,7 @@ JH/06 Bug 1533: Fix truncation of items in headers_remove lists. A fixed JH/07 Add support for directories of certificates when compiled with a GnuTLS version 3.3.6 or later. -JH/08 Rename the TPDA expermimental facility to Event Actions. The #ifdef +JH/08 Rename the TPDA experimental facility to Event Actions. The #ifdef is EXPERIMENTAL_EVENT, the main-configuration and transport options both become "event_action", the variables become $event_name, $event_data and $event_defer_errno. There is a new variable $verify_mode, usable in @@ -574,7 +857,7 @@ TL/07 Bug 1547: Omit RFCs from release. Draft and RFCs have licenses which JH/15 Updates and fixes to the EXPERIMENTAL_DSN feature. -JH/16 Fix string representation of time values on 64bit time_t anchitectures. +JH/16 Fix string representation of time values on 64bit time_t architectures. Bug 1561. JH/17 Fix a null-indirection in certextract expansions when a nondefault @@ -588,7 +871,7 @@ TL/01 Bugzilla 1506: Re-add a 'return NULL' to silence complaints from static return. JH/01 Bug 1513: Fix parsing of quoted parameter values in MIME headers. - This was a regression intruduced in 4.83 by another bugfix. + This was a regression introduced in 4.83 by another bugfix. JH/02 Fix broken compilation when EXPERIMENTAL_DSN is enabled. @@ -919,7 +1202,7 @@ JH/14 SMTP PRDR (http://www.eric-a-hall.com/specs/draft-hall-prdr-00.txt). advertises the facility. If the client requests PRDR a new acl_data_smtp_prdr ACL is called once for each recipient, after the body content is received and before the acl_smtp_data ACL. - The client is controlled by bolth of: a hosts_try_prdr option + The client is controlled by both of: a hosts_try_prdr option on the smtp transport, and the server advertisement. Default client logging of deliveries and rejections involving PRDR are flagged with the string "PRDR". @@ -947,7 +1230,7 @@ PP/20 Added force_command boolean option to pipe transport. JH/15 AUTH support on callouts (and hence cutthrough-deliveries). Bugzilla 321, 823. -TF/04 Added udpsend ACL modifer and hexquote expansion operator +TF/04 Added udpsend ACL modifier and hexquote expansion operator PP/21 Fix eximon continuous updating with timestamped log-files. Broken in a format-string cleanup in 4.80, missed when I repaired the @@ -1091,7 +1374,7 @@ PP/15 LDAP: Check for errors of TLS initialisation, to give correct diagnostics. Report and patch from Dmitry Banschikov. -PP/16 Removed "dont_insert_empty_fragments" fron "openssl_options". +PP/16 Removed "dont_insert_empty_fragments" from "openssl_options". Removed SSL_clear() after SSL_new() which led to protocol negotiation failures. We appear to now support TLS1.1+ with Exim. @@ -1221,7 +1504,7 @@ TF/04 Improved ratelimit ACL condition. has clearer semantics. The /leaky, /strict, and /readonly update modes are mutually exclusive. The update mode is no longer included in the database key; it just determines when the database is updated. (This - means that when you upgrde Exim will forget old rate measurements.) + means that when you upgrade Exim will forget old rate measurements.) Exim now checks that the per_* options are used with an update mode that makes sense for the current ACL. For example, when Exim is processing a @@ -1356,7 +1639,7 @@ PP/09 Fix another SIGFPE (x86) in ${eval:...} expansion, this time related to Exim version 4.75 ----------------- -NM/01 Workround for PCRE version dependency in version reporting +NM/01 Workaround for PCRE version dependency in version reporting Bugzilla 1073 TF/01 Update valgrind.h and memcheck.h to copies from valgrind-3.6.0. @@ -1426,7 +1709,7 @@ NM/05 Fix to spam.c to accommodate older gcc versions which dislike variable declaration deep within a block. Bug and patch from Dennis Davis. -PP/15 lookups-Makefile IRIX compatibilty coercion. +PP/15 lookups-Makefile IRIX compatibility coercion. PP/16 Make DISABLE_DKIM build knob functional. @@ -1851,7 +2134,7 @@ PH/02 When an IPv6 address is converted to a string for single-key lookup colons if the lookup type is iplsearch. This is not incompatible, because previously such lookups could never work. - The situation is now rather anomolous, since one *can* have colons in + The situation is now rather anomalous, since one *can* have colons in ordinary lsearch keys. However, making the change in all cases is incompatible and would probably break a number of configurations. @@ -2021,7 +2304,7 @@ PH/19 Change 4.64/PH/36 introduced a bug: when address_retry_include_sender PH/20 Added hosts_avoid_pipelining to the smtp transport. PH/21 Long custom messages for fakedefer and fakereject are now split up - into multiline reponses in the same way that messages for "deny" and + into multiline responses in the same way that messages for "deny" and other ACL rejections are. PH/22 Applied Jori Hamalainen's speed-up changes and typo fixes to exigrep, @@ -2428,7 +2711,7 @@ PH/36 After a 4xx response to a RCPT error, that address was delayed (in queue runs only) independently of the message's sender address. This meant that, if the 4xx error was in fact related to the sender, a different message to the same recipient with a different sender could confuse - things. In particualar, this can happen when sending to a greylisting + things. In particular, this can happen when sending to a greylisting server, but other circumstances could also provoke similar problems. I have changed the default so that the retry time for these errors is now based a combination of the sender and recipient addresses. This change @@ -2497,7 +2780,7 @@ SC/08 Eximstats V1.50 JJ/03 exipick.20061117.2, made header handling as similar to exim as possible (added [br]h_ prefixes, implemented RFC2047 decoding. Fixed - whitesspace changes from 4.64-PH/27 + whitespace changes from 4.64-PH/27 JJ/04 exipick.20061117.2, fixed format and added $message_headers_raw to match 4.64-PH/13 @@ -2819,7 +3102,7 @@ PH/14 When a uid/gid is specified for the queryprogram router, it cannot be (a) Failures to set uid/gid, the current directory, or a process leader in a subprocess such as that created by queryprogram now generate - suitable debugging ouput when -d is set. + suitable debugging output when -d is set. (b) The queryprogram router detects when it is not running as root, outputs suitable debugging information if -d is set, and then runs @@ -3179,7 +3462,7 @@ PH/09 Applied a patch from the Sieve maintainer which: and most important: o fixes a bug in processing the envelope test (when testing - multiple envelope elements, the last element determinted the + multiple envelope elements, the last element determined the result) PH/10 Exim was violating RFC 3834 ("Recommendations for Automatic Responses to @@ -3188,7 +3471,7 @@ PH/10 Exim was violating RFC 3834 ("Recommendations for Automatic Responses to Auto-submitted: auto-generated in the messages that it generates (bounce messages and others, such as - warnings). In the case of bounce messages for non-SMTP mesages, there was + warnings). In the case of bounce messages for non-SMTP messages, there was also a typo: it was using "Auto_submitted" (underscore instead of hyphen). Since every message generated by Exim is necessarily in response to another message, thes have all been changed to: @@ -3553,7 +3836,7 @@ TK/03 Merged latest SRS patch from Miles Wilton. PH/05 There's a shambles in IRIX6 - it defines EX_OK in unistd.h which conflicts with the definition in sysexits.h (which is #included earlier). Fortunately, Exim does not actually use EX_OK. The code used to try to - preserve the sysexits.h value, by assumimg that macro definitions were + preserve the sysexits.h value, by assuming that macro definitions were scanned for macro replacements. I have been disabused of this notion, so now the code just undefines EX_OK before #including unistd.h. @@ -3573,7 +3856,7 @@ PH/07 Added "fullpostmaster" verify option, which does a check to SC/01 Eximstats: added -xls and the ability to specify output files (patch written by Frank Heydlauf). -SC/02 Eximstats: use FileHandles for outputing results. +SC/02 Eximstats: use FileHandles for outputting results. SC/03 Eximstats: allow any combination of xls, txt, and html output. @@ -5598,7 +5881,7 @@ Exim version 4.31 58. When a "warn" ACL statement has a log_message modifier, the message is remembered, and not repeated. This is to avoid a lot of repetition when a message has many recipients that cause the same warning to be written. - Howewer, Exim was preserving the list of already written lines for an + However, Exim was preserving the list of already written lines for an entire SMTP session, which doesn't seem right. The memory is now reset if a new message is started. @@ -5688,7 +5971,7 @@ Exim version 4.31 the list was checked. (An example that provoked this was putting <; in the middle of a list instead of at the start.) If this happened during a DATA ACL check, a -D file could be left lying around. This kind of configuration - error no longer causes Exim to die; instead it causes a defer errror. The + error no longer causes Exim to die; instead it causes a defer error. The incident is still logged to the main and panic logs. 74. Buglet left over from Exim 3 conversion. The message "too many messages @@ -5752,7 +6035,7 @@ Exim version 4.30 systems (e.g. Solaris), it also passes back the IP address string as the "host name". However, on others (e.g. Linux), it passes back an empty string. Exim wasn't checking for this, and was changing the host name to an - empty string, assuming it had been canonicized. + empty string, assuming it had been canonicalized. 5. Although rare, it is permitted to have more than one PTR record for a given IP address. I thought that gethostbyaddr() or getipnodebyaddr() always gave @@ -5804,7 +6087,7 @@ Exim version 4.30 13. The install script calls Exim with "-C /dev/null" in order to find the version number. If ALT_CONFIG_PREFIX was set, this caused an error message - to be output. Howeve, since Exim outputs its version number before the + to be output. However, since Exim outputs its version number before the error, it didn't break the script. It just looked ugly. I fixed this by always allowing "-C /dev/null" if the caller is root. @@ -5885,7 +6168,7 @@ Exim version 4.30 34. Testing for a connection timeout using "timeout_connect" in the retry rules did not work. The code looks as if it has *never* worked, though it appears - to have been documented since at least releast 1.62. I have made it work. + to have been documented since at least release 1.62. I have made it work. 35. The "timeout_DNS" error in retry rules, also documented since at least 1.62, also never worked. As it isn't clear exactly what this means, and @@ -6330,7 +6613,7 @@ Exim version 4.21 16. Check for letters, digits, hyphens, and dots in the names of dnslist domains, and warn by logging if others are found. -17. At least on BSD, alignment is not guarenteed for the array of ifreq's +17. At least on BSD, alignment is not guaranteed for the array of ifreq's returned from GIFCONF when Exim is trying to find the list of interfaces on a host. The code in os.c has been modified to copy each ifreq to an aligned structure in all cases. @@ -6364,7 +6647,7 @@ Exim version 4.21 24. Ignore Sendmail's -Ooption=value command line item. 25. When execve() failed while trying to run a command in a pipe transport, - Exim was returning EX_UNAVAILBLE (69) from the subprocess. However, this + Exim was returning EX_UNAVAILABLE (69) from the subprocess. However, this could be confused with a return value of 69 from the command itself. This has been changed to 127, the value the shell returns if it is asked to run a non-existent command. The wording for the related log line suggests a @@ -6477,7 +6760,7 @@ Exim version 4.21 47. Change 50 for 4.20 was a heap of junk. I don't know what I was thinking when I implemented it. It didn't allow for the fact that some option values - may legitimatetly be negative (e.g. size_addition), and it didn't even do + may legitimately be negative (e.g. size_addition), and it didn't even do the right test for positive values. 48. Domain names in DNS records are case-independent. Exim always looks them up