From: Heiko Schlittermann (HS12-RIPE) <hs@schlittermann.de>
Date: Fri, 11 Mar 2016 22:44:53 +0000 (+0100)
Subject: Don't issue env warning if env is empty
X-Git-Tag: exim-4_87_RC7~15
X-Git-Url: https://git.exim.org/users/heiko/exim.git/commitdiff_plain/8e58ed807c77febfde61d3cf47928302f93cc99c

Don't issue env warning if env is empty

keep_environment needs to be mentioned in the runtime config.
Setting add_environment isn't enough to suppress the warning.
---

diff --git a/doc/doc-docbook/spec.xfpt b/doc/doc-docbook/spec.xfpt
index 33d9c34cb..1239b1690 100644
--- a/doc/doc-docbook/spec.xfpt
+++ b/doc/doc-docbook/spec.xfpt
@@ -15115,9 +15115,10 @@ FOO and having FOO_HOME in your &%keep_environment%& option may have
 unexpected results. You may work around this using a regular expression
 that does not match the macro name: ^[F]OO_HOME$.
 
-Current versions of Exim issue a warning during startupif you do not mention
-&%keep_environment%& or &%add_environment%& in your runtime configuration
-file.
+Current versions of Exim issue a warning during startup if you do not mention
+&%keep_environment%& in your runtime configuration file and if there is
+anything in your environment. Future versions may not issue that warning
+anymore.
 .wen
 
 
diff --git a/src/src/readconf.c b/src/src/readconf.c
index 328d49558..0f696cbf5 100644
--- a/src/src/readconf.c
+++ b/src/src/readconf.c
@@ -3503,10 +3503,10 @@ if (gnutls_require_kx || gnutls_require_mac || gnutls_require_proto)
       " are obsolete\n");
 #endif	/*SUPPORT_TLS*/
 
-if ((!add_environment || *add_environment == '\0') && !keep_environment)
+if (!keep_environment && environ && *environ)
   log_write(0, LOG_MAIN,
-      "WARNING: purging the environment.\n"
-      " Suggested action: use keep_environment and add_environment.");
+      "Warning: purging the environment.\n"
+      " Suggested action: use keep_environment.");
 }
 
 
diff --git a/test/confs/0615 b/test/confs/0615
index bbfc4978a..86ecee108 100644
--- a/test/confs/0615
+++ b/test/confs/0615
@@ -1,6 +1,7 @@
 # exim test configuration 0615
 exim_path = EXIM_PATH
 tls_advertise_hosts =
+spool_directory = DIR/spool
 perl_startup = $| = 1; \
 	print "Environment visible in Perl:\n"; \
 	print map { "$_=$ENV{$_}\n" } sort keys %ENV;
diff --git a/test/stderr/0615 b/test/stderr/0615
index 85ee6f760..d8d0f8547 100644
--- a/test/stderr/0615
+++ b/test/stderr/0615
@@ -1,15 +1,11 @@
 LOG: MAIN
-  WARNING: purging the environment.
- Suggested action: use keep_environment and add_environment.
-
+  Warning: purging the environment.
+ Suggested action: use keep_environment.
 LOG: MAIN
-  WARNING: purging the environment.
- Suggested action: use keep_environment and add_environment.
-
+  Warning: purging the environment.
+ Suggested action: use keep_environment.
 LOG: MAIN
-  WARNING: purging the environment.
- Suggested action: use keep_environment and add_environment.
-
-1999-03-02 09:44:33 WARNING: purging the environment.
- Suggested action: use keep_environment and add_environment.
-
+  Warning: purging the environment.
+ Suggested action: use keep_environment.
+1999-03-02 09:44:33 Warning: purging the environment.
+ Suggested action: use keep_environment.