From 9852336a0e497e2f2ef5e12919ac602defef957b Mon Sep 17 00:00:00 2001 From: Phil Pennock Date: Mon, 14 Jul 2014 03:13:13 -0400 Subject: [PATCH] DNSSEC: fix clang warning re && in || precedence I looked and AFAICT the compiler guidance gives the correct logical binding for the code intention. ``` dnsdb.c:362:32: warning: '&&' within '||' [-Wlogical-op-parentheses] || dnssec_mode == DEFER && !dns_is_secure(&dnsa) ~~ ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ dnsdb.c:362:32: note: place parentheses around the '&&' expression to silence this warning || dnssec_mode == DEFER && !dns_is_secure(&dnsa) ^ ( ) ``` --- src/src/lookups/dnsdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/src/lookups/dnsdb.c b/src/src/lookups/dnsdb.c index 6b4d55c4d..fde98b977 100644 --- a/src/src/lookups/dnsdb.c +++ b/src/src/lookups/dnsdb.c @@ -359,7 +359,7 @@ while ((domain = string_nextinlist(&keystring, &sep, buffer, sizeof(buffer))) if (rc == DNS_NOMATCH || rc == DNS_NODATA) continue; if ( rc != DNS_SUCCEED - || dnssec_mode == DEFER && !dns_is_secure(&dnsa) + || (dnssec_mode == DEFER && !dns_is_secure(&dnsa)) ) { if (defer_mode == DEFER) -- 2.30.2