From: Jeremy Harris <jgh146exb@wizmail.org>
Date: Sun, 12 Apr 2020 21:24:21 +0000 (+0100)
Subject: Better fix for crash
X-Git-Tag: exim-4_94_RC0~21
X-Git-Url: https://git.exim.org/exim.git/commitdiff_plain/f82c06aac7959d473020a68bb24a74690a1ac5ef

Better fix for crash

Broken-by: 0b4dfe7aa1
---

diff --git a/src/src/verify.c b/src/src/verify.c
index 73d2d7659..9955bd1ff 100644
--- a/src/src/verify.c
+++ b/src/src/verify.c
@@ -2945,17 +2945,20 @@ if (*t == 0 || (*t == '/' && t != ss))
   return ERROR;
   }
 
-/* See if there is a semicolon in the pattern */
+/* See if there is a semicolon in the pattern, separating a searchtype
+prefix.  If there is one then check for comma-sep options. */
 
 if ((semicolon = Ustrchr(ss, ';')))
-  {
-  endname = (opts = Ustrchr(ss, ',')) ? opts : semicolon;
-  if (opts)
+  if ((opts = Ustrchr(ss, ',')) && opts < semicolon)
     {
-    opts++;
+    endname = opts++;
     opts = string_copyn(opts, semicolon - opts);
     }
-  }
+  else
+    {
+    endname = semicolon;
+    opts = NULL;
+    }
 
 /* If we are doing an IP address only match, then all lookups must be IP
 address lookups, even if there is no "net-". */