From: Jeremy Harris Date: Mon, 18 Sep 2017 16:47:52 +0000 (+0100) Subject: SOCKS: fix unitialized-pointer X-Git-Tag: exim-4_89_1~7 X-Git-Url: https://git.exim.org/exim.git/commitdiff_plain/70a6b3e5af741d2ec3fb1501875235a28c7bf33e?ds=sidebyside SOCKS: fix unitialized-pointer --- diff --git a/doc/doc-txt/ChangeLog b/doc/doc-txt/ChangeLog index afd41e40a..089aeb774 100644 --- a/doc/doc-txt/ChangeLog +++ b/doc/doc-txt/ChangeLog @@ -43,6 +43,9 @@ JH/26 Fix DKIM bug: when the pseudoheader generated for signing was exactly line, the header hash was calculated to an incorrect value thanks to the (relaxed) space the fold became. +JH/27 Fix SOCKS bug: an unitialized pointer was deref'd by the transport process + which could crash as a result. This could lead to undeliverable messages. + Exim version 4.89 ----------------- diff --git a/src/src/transports/smtp_socks.c b/src/src/transports/smtp_socks.c index 555843068..92d13659d 100644 --- a/src/src/transports/smtp_socks.c +++ b/src/src/transports/smtp_socks.c @@ -285,7 +285,7 @@ for(;;) sob = &proxies[idx]; /* bodge up a host struct for the proxy */ - proxy.address = sob->proxy_host; + proxy.address = proxy.name = sob->proxy_host; proxy_af = Ustrchr(sob->proxy_host, ':') ? AF_INET6 : AF_INET; if ((fd = smtp_sock_connect(&proxy, proxy_af, sob->port,