From: Lars Mueller <lmuelle@suse.com>
Date: Wed, 23 Jul 2014 14:22:52 +0000 (-0700)
Subject: Bug 1506: Silence static checkers.
X-Git-Tag: exim-4_84_RC1~6
X-Git-Url: https://git.exim.org/exim.git/commitdiff_plain/6c08476d09bf337921e7ba73e109e5f72fddfdf9?hp=cc4a2e40ed9f114108a72ee8cfaa453ce478e833

Bug 1506: Silence static checkers.

Re-adds a return NULL which was removed because it was redundant. Static
  checkers don't parse the logic, so adding it back to make them happy.
---

diff --git a/src/src/expand.c b/src/src/expand.c
index 23009bc4f..70d7c7d2f 100644
--- a/src/src/expand.c
+++ b/src/src/expand.c
@@ -1879,7 +1879,8 @@ switch (vp->type)
   #endif
 
   }
-return NULL;  /* Fix broken static checkers, already done in if() above */
+
+return NULL;  /* Unknown variable. Silences static checkers. */
 }