From: Jeremy Harris Date: Sun, 7 Aug 2016 22:19:02 +0000 (+0100) Subject: Revert "DKIM: reduce memory usage" X-Git-Tag: exim-4_88_RC1~47 X-Git-Url: https://git.exim.org/exim.git/commitdiff_plain/5899e332cfbf8e85f23256203ab0b802b47a22d1?ds=inline Revert "DKIM: reduce memory usage" This reverts commit dea4897244b409bf91dc60a7e5e4b3d06f123dd6. It appears to induce spurious behaviour, seen in the testsuite. Possibly the sha_hash update calls think the memory they are passed will still be around later (eg. at sha_finish time)? A pity, since currently we are allocating for the entire message body - which could easily be MB or (future) GB. --- diff --git a/src/src/pdkim/pdkim.c b/src/src/pdkim/pdkim.c index 09a745a25..f468d232b 100644 --- a/src/src/pdkim/pdkim.c +++ b/src/src/pdkim/pdkim.c @@ -767,7 +767,6 @@ while (sig) sig = sig->next; } -if (relaxed_data) store_reset(relaxed_data); return PDKIM_OK; }