From: Heiko Schlittermann (HS12-RIPE) Date: Thu, 2 Feb 2017 08:21:13 +0000 (+0100) Subject: Testsuite: tidy generation and sorting of exim -bp output X-Git-Tag: exim-4_89_RC3~8 X-Git-Url: https://git.exim.org/exim.git/commitdiff_plain/562a0e6f53f497710939fd7b4d16dd936919245c Testsuite: tidy generation and sorting of exim -bp output The root cause is, that exim -bp doesn't always return the message ids in the order they were created, but sorted. The 2nd part of the message id (PID) can be random on *BSD. --- diff --git a/test/runtest b/test/runtest index ac840379c..b2f5d0775 100755 --- a/test/runtest +++ b/test/runtest @@ -2266,22 +2266,20 @@ elsif (/^((?i:[A-Z\d_]+=\S+\s+)+)?(\d+)?\s*(sudo(?:\s+-u\s+(\w+))?\s+)?exim(_\S+ if ($args =~ /\$msg/) { - my($listcmd) = "$parm_cwd/eximdir/exim -bp " . - "-DEXIM_PATH=$parm_cwd/eximdir/exim " . - "-C $parm_cwd/test-config |"; - print ">> Getting queue list from:\n>> $listcmd\n" if ($debug); - open (QLIST, $listcmd) || tests_exit(-1, "Couldn't run \"exim -bp\": $!\n"); - my(@msglist) = (); - while () { push (@msglist, $1) if /^\s*\d+[smhdw]\s+\S+\s+(\S+)/; } - close(QLIST); + my @listcmd = ("$parm_cwd/eximdir/exim", '-bp', + "-DEXIM_PATH=$parm_cwd/eximdir/exim", + -C => "$parm_cwd/test-config"); + print ">> Getting queue list from:\n>> @listcmd\n" if $debug; # We need the message ids sorted in ascending order. # Message id is: --. On some systems (*BSD) the # PIDs are randomized, so sorting just the whole PID doesn't work. # We do the Schartz' transformation here (sort on # ). Thanks to Kirill Miazine - @msglist = map { $_->[0] } - sort { $a->[1] cmp $b->[1] } - map { [$_, join '', (split '-', $_)[0,2]] } @msglist; + my @msglist = + map { $_->[1] } # extract the values + sort { $a->[0] cmp $b->[0] } # sort by key + map { [join('.' => (split /-/, $_)[0,2]) => $_] } # key (timestamp.fractional-time) => value(message_id) + map { /^\s*\d+[smhdw]\s+\S+\s+(\S+)/ } `@listcmd` or tests_exit(-1, "No output from `exim -bp` (@listcmd)\n"); # Done backwards just in case there are more than 9