Jeremy Harris [Sat, 14 Oct 2017 18:16:59 +0000 (19:16 +0100)]
Tidy build for OpenBSD
Jeremy Harris [Sat, 14 Oct 2017 14:37:01 +0000 (15:37 +0100)]
coding standards
Jeremy Harris [Thu, 12 Oct 2017 21:05:14 +0000 (22:05 +0100)]
String handling: refactor the expanding-string routines and users to use a descriptor struct
Heiko Schlittermann (HS12-RIPE) [Fri, 13 Oct 2017 22:24:54 +0000 (00:24 +0200)]
Fix mariadb/mysql macro confusion
Jeremy Harris [Fri, 13 Oct 2017 16:05:59 +0000 (17:05 +0100)]
Testsuite: add cipher-suite seen on OpenBSD
Jeremy Harris [Thu, 12 Oct 2017 17:20:56 +0000 (18:20 +0100)]
Testsuite: openssl variant debug output
Jeremy Harris [Thu, 12 Oct 2017 13:03:08 +0000 (14:03 +0100)]
Fix queue_run_in_order to ignore the PID portion of the message ID
Jeremy Harris [Tue, 10 Oct 2017 20:39:54 +0000 (21:39 +0100)]
MySQL: fix build on Fedora 27, where MariaDB version information has become unavailable
Jeremy Harris [Tue, 10 Oct 2017 20:38:42 +0000 (21:38 +0100)]
Fix FreeBSD build (again)
Jeremy Harris [Tue, 10 Oct 2017 12:09:43 +0000 (13:09 +0100)]
Avoid build conflict vs. FreeBSD /usr/include/sys/file.h
Jeremy Harris [Sun, 8 Oct 2017 18:00:37 +0000 (19:00 +0100)]
Fix debug_printf data size
Jeremy Harris [Sun, 8 Oct 2017 17:56:13 +0000 (18:56 +0100)]
Logging: show when input from truncated for logging "next input sent too soon"
Jeremy Harris [Sun, 8 Oct 2017 16:34:16 +0000 (17:34 +0100)]
TFO: early-data for identd queries
Jeremy Harris [Sun, 8 Oct 2017 15:12:06 +0000 (16:12 +0100)]
TFO: on FreeBSD avoid client TFO-mode connects unless a TCP_FASTOPEN setsocketopt succeeds
This fixes the FreeSBD no-kernel-support issues (it succeded the sendto for the
connect-with-data, but dod not queue the data). Having checked dynamically, do
not claim support-for TFO either.
Jeremy Harris [Sat, 7 Oct 2017 13:36:52 +0000 (14:36 +0100)]
Fix identd connections on FreeBSD under TCP Fast Open
Jeremy Harris [Fri, 6 Oct 2017 21:58:39 +0000 (22:58 +0100)]
Testsuite: accept different debug detail for peer-terminated connection
Jeremy Harris [Fri, 6 Oct 2017 21:18:30 +0000 (22:18 +0100)]
Use flag names rather than values in debug output
The values differ between Linux and FreeBSD
Heiko Schlittermann (HS12-RIPE) [Wed, 4 Oct 2017 20:25:45 +0000 (22:25 +0200)]
Check for proper output separator in expanding ${addresses:STRING} (Closes 2171)
Better yet would be to force setting the output separator literally,
and not after expansion of the STRING. But this would be an incompatible
change.
Jeremy Harris [Fri, 6 Oct 2017 17:11:22 +0000 (18:11 +0100)]
Better handling of printing NULL pointers
Jeremy Harris [Thu, 5 Oct 2017 21:41:03 +0000 (22:41 +0100)]
testsuite output changes
Jeremy Harris [Thu, 5 Oct 2017 20:54:28 +0000 (21:54 +0100)]
Fix debug output for NULL pointers on FreeBSD.
The testsuite had failures, mostly in DB opens finding no existing file,
where debug output to stderr showed "0xAAAAAAAA" rather than "(nil)".
Code it explicitly, at least in %p handling, rather than relying on sprintf() bevahiour.
Jeremy Harris [Sun, 1 Oct 2017 20:45:11 +0000 (21:45 +0100)]
Testsuite: for TFO testcases manipulate the system state
Linux-centric; will need elaboration for other platforms
Jeremy Harris [Sun, 1 Oct 2017 17:11:36 +0000 (18:11 +0100)]
TFO: better detection of client fast-open connections (again)
Jeremy Harris [Mon, 25 Sep 2017 17:53:12 +0000 (18:53 +0100)]
Testsuite: Ignore optional-config output change
Jeremy Harris [Mon, 25 Sep 2017 15:36:47 +0000 (16:36 +0100)]
DKIM: support specifying alternate-identity tag for signing. Bug 2170
Jeremy Harris [Tue, 19 Sep 2017 20:57:30 +0000 (21:57 +0100)]
TFO: early-data for ClamAV and for readsocket expansion
Jeremy Harris [Tue, 19 Sep 2017 20:45:10 +0000 (21:45 +0100)]
Avoid repeated string-copy building command-string for rspamd
Jeremy Harris [Tue, 19 Sep 2017 14:10:21 +0000 (15:10 +0100)]
TFO: better detection of client fast-open connections
Jeremy Harris [Tue, 19 Sep 2017 12:24:43 +0000 (13:24 +0100)]
Fix testsuite build for non-TFO platforms
Jeremy Harris [Mon, 18 Sep 2017 10:50:07 +0000 (11:50 +0100)]
TFO: early-data for client outbound via socks5 proxy
Heiko Schlittermann (HS12-RIPE) [Mon, 18 Sep 2017 20:56:36 +0000 (22:56 +0200)]
exipick: add -C|--config option
This fits better to
echo test | exim -C /tmp/test.conf -v test@example.com
exipick -C /tmp/test.conf
Jeremy Harris [Mon, 18 Sep 2017 16:47:52 +0000 (17:47 +0100)]
SOCKS: fix unitialized-pointer
Jeremy Harris [Sat, 16 Sep 2017 22:43:54 +0000 (23:43 +0100)]
tidying
Jeremy Harris [Sat, 16 Sep 2017 17:05:57 +0000 (18:05 +0100)]
Fix build on FreeBSD
Jeremy Harris [Sat, 16 Sep 2017 16:32:37 +0000 (17:32 +0100)]
Fix function prototype
Jeremy Harris [Sat, 16 Sep 2017 16:11:20 +0000 (17:11 +0100)]
Support parallel-build for the buildtin macros
Jeremy Harris [Sat, 16 Sep 2017 15:03:32 +0000 (16:03 +0100)]
tidying
Heiko Schlittermann (HS12-RIPE) [Sat, 16 Sep 2017 13:13:15 +0000 (15:13 +0200)]
Provide readn() as a wrapper around read()
This readn() reads all the data requested, even if the
writer sends it in smaller chunks.
Heiko Schlittermann (HS12-RIPE) [Thu, 29 Jun 2017 18:13:40 +0000 (20:13 +0200)]
Use writev(2) when sending delivery status to the parent
Heiko Schlittermann (HS12-RIPE) [Wed, 5 Jul 2017 06:47:56 +0000 (08:47 +0200)]
Do not use O_NONBLOCK for reading the delivery transport pipe
Jeremy Harris [Tue, 12 Sep 2017 19:27:19 +0000 (20:27 +0100)]
Tidy build under pre-v3 GnuTLS
Jeremy Harris [Tue, 12 Sep 2017 16:49:58 +0000 (17:49 +0100)]
DKIM: support multiple signing, by selector
Jeremy Harris [Tue, 12 Sep 2017 16:37:48 +0000 (17:37 +0100)]
DKIM: support multiple hash methods
Jeremy Harris [Fri, 19 May 2017 12:32:53 +0000 (13:32 +0100)]
DKIM: rename internal signing api
Jeremy Harris [Sun, 10 Sep 2017 19:23:21 +0000 (20:23 +0100)]
DKIM: fix signing bug induced by total size of parameter text
causing header-line fold between "b=" and terminating ";" of
pseudo-header.
Jeremy Harris [Fri, 8 Sep 2017 18:24:40 +0000 (19:24 +0100)]
specified-initialisers
Phil Pennock [Tue, 5 Sep 2017 00:24:56 +0000 (20:24 -0400)]
Fix sieve QP regression from Coverity cleanups
Fixes: 2161
Jeremy Harris [Sat, 2 Sep 2017 15:16:43 +0000 (16:16 +0100)]
Logging: restrict TFO client-side to Linux
The detection method depends on a getsockopt struct member apparently
not supported by FreeBSD (at least). Other platforms status unknown.
Jeremy Harris [Wed, 30 Aug 2017 22:52:40 +0000 (23:52 +0100)]
Logging: TCP Fast Open
Jeremy Harris [Mon, 21 Aug 2017 19:46:52 +0000 (20:46 +0100)]
Fix address ignore-errors flag bit initialisation and propagation
Broken-by: 7eb0e5d2b8
Jaroslav Škarvada [Fri, 18 Aug 2017 13:57:19 +0000 (15:57 +0200)]
Fixed compilation with mariadb-10.2
https://bugzilla.redhat.com/show_bug.cgi?id=
1467312
Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
Exim-merge-changes: added ChangeLog item (Phil Pennock)
Jeremy Harris [Sun, 20 Aug 2017 21:09:15 +0000 (22:09 +0100)]
Use bitfields for flags in the "addr" struct
Jeremy Harris [Sun, 20 Aug 2017 12:42:16 +0000 (13:42 +0100)]
Logging: add elapsed-time element to unexpected-diconnection lines
Jeremy Harris [Mon, 14 Aug 2017 14:04:24 +0000 (15:04 +0100)]
tidying
Jeremy Harris [Mon, 14 Aug 2017 12:35:22 +0000 (13:35 +0100)]
tidying
Jeremy Harris [Sun, 13 Aug 2017 20:36:25 +0000 (21:36 +0100)]
Fix EXPERIMENTAL_DMARC build
Broken-by: f2ed27cf5f
Jeremy Harris [Sun, 13 Aug 2017 14:16:08 +0000 (15:16 +0100)]
Fix non-TLS build
Broken-by: e5de01f091
Jeremy Harris [Sun, 13 Aug 2017 14:12:27 +0000 (15:12 +0100)]
Typo
Broken-by: f2ed27cf5f
Jeremy Harris [Sun, 13 Aug 2017 10:07:33 +0000 (11:07 +0100)]
Document CVE assignment for Berkeley DB issue
Jeremy Harris [Mon, 7 Aug 2017 14:33:14 +0000 (15:33 +0100)]
Coding: use specified-initialisers
Jeremy Harris [Wed, 9 Aug 2017 22:39:25 +0000 (23:39 +0100)]
Use exim string facilities rather than custom parser for DKIM pubkey
Jeremy Harris [Wed, 28 Jun 2017 14:25:12 +0000 (15:25 +0100)]
DKIM: Enforce any "h" field present in the DNS publickey record. This can be set to require specific
hash types, eg sha256, in signatues. There is an IETF draft in discussion which deprecates sha1 so this
feature may start to be used.
Jeremy Harris [Sun, 6 Aug 2017 14:44:13 +0000 (15:44 +0100)]
Logging: millisecond time on 'no MAIL' lines. Bug 2102
Jeremy Harris [Sat, 5 Aug 2017 14:51:36 +0000 (15:51 +0100)]
tidying
Jeremy Harris [Sat, 5 Aug 2017 14:04:39 +0000 (15:04 +0100)]
tidying
Jeremy Harris [Sat, 5 Aug 2017 13:06:36 +0000 (14:06 +0100)]
Debugging: millisecond timestamps. Bug 2102
Jeremy Harris [Fri, 4 Aug 2017 14:13:17 +0000 (15:13 +0100)]
Logging: millisecond QT and DT. Bug 2102
Jeremy Harris [Tue, 1 Aug 2017 20:49:04 +0000 (21:49 +0100)]
Use retval from sprintf while walking buffers
Jeremy Harris [Sun, 16 Jul 2017 16:21:35 +0000 (17:21 +0100)]
Tidying
Jeremy Harris [Sun, 30 Jul 2017 19:51:10 +0000 (20:51 +0100)]
Logging: millisecond timestamps. Bug 2102
No change to QT logging yet as that will need a spool format update
Jeremy Harris [Sun, 30 Jul 2017 13:37:56 +0000 (14:37 +0100)]
Retire historical build files from Makefile
Jeremy Harris [Sun, 30 Jul 2017 13:21:43 +0000 (14:21 +0100)]
Retire historical build files
Jeremy Harris [Sat, 22 Jul 2017 15:38:08 +0000 (16:38 +0100)]
On callout avoid SIZE every time but noncacheable rcpt main-verify. Bug 2151
Jeremy Harris [Tue, 18 Jul 2017 22:29:54 +0000 (23:29 +0100)]
Do not rely on linker identifying common strings
Jeremy Harris [Tue, 18 Jul 2017 22:10:33 +0000 (23:10 +0100)]
Fix cache-cold random callout verify. Bug 2147
Jeremy Harris [Sun, 16 Jul 2017 17:02:57 +0000 (18:02 +0100)]
Optimise scanning config for macros
Jeremy Harris [Sun, 16 Jul 2017 13:36:38 +0000 (14:36 +0100)]
Fix macro_predef build for auth_cyrus_sasl
Jeremy Harris [Sun, 16 Jul 2017 12:52:57 +0000 (13:52 +0100)]
Fix build for earlier version Berkeley DB
Jeremy Harris [Sat, 15 Jul 2017 18:55:59 +0000 (19:55 +0100)]
tidying
Jeremy Harris [Wed, 5 Jul 2017 11:57:24 +0000 (12:57 +0100)]
Use the BDB "environment" so that a database config file is not looked for. Bug 2141
Jeremy Harris [Tue, 11 Jul 2017 19:52:34 +0000 (20:52 +0100)]
Add directory name as new arg to EXIM_DBOPEN
Jeremy Harris [Wed, 5 Jul 2017 13:30:05 +0000 (14:30 +0100)]
Add $smtp_command_history variable
Jeremy Harris [Sun, 9 Jul 2017 15:12:45 +0000 (16:12 +0100)]
tidying
Jeremy Harris [Sun, 9 Jul 2017 13:29:31 +0000 (14:29 +0100)]
Avoid creating before-buffer pointer. Bug 2145
Found by: ASAN / <ago@gentoo.org>
Jeremy Harris [Sat, 8 Jul 2017 16:54:44 +0000 (17:54 +0100)]
Prebuild the data structure for builtin macros
Jeremy Harris [Sat, 8 Jul 2017 12:24:38 +0000 (13:24 +0100)]
Prebuild the data structure for builtin macros
Jeremy Harris [Sat, 8 Jul 2017 12:59:49 +0000 (13:59 +0100)]
Split macro name storage out from macro definition struct
Heiko Schlittermann (HS12-RIPE) [Tue, 4 Jul 2017 11:33:08 +0000 (13:33 +0200)]
exigrep: use less --quite-if-one-screen --no-init
Jeremy Harris [Sun, 2 Jul 2017 09:30:48 +0000 (10:30 +0100)]
Transform string_append_listele{,_n}() to proper expanding-string triplet interface
(but do always maintain a nul-term string result). This avoids always copying the
previous list version, and should do fewer allocs too.
Heiko Schlittermann (HS12-RIPE) [Fri, 30 Jun 2017 15:22:08 +0000 (17:22 +0200)]
Configure the default opendmarc.tlds file in EDITME
Heiko Schlittermann (HS12-RIPE) [Thu, 29 Jun 2017 10:42:12 +0000 (12:42 +0200)]
Build: set LC_ALL=C for the makefile configuration
Otherwise Perl may complain about missing locales, which
in turn confuses the Configure-Makefile script when parsing
the output from Perl
Heiko Schlittermann (HS12-RIPE) [Wed, 28 Jun 2017 21:42:17 +0000 (23:42 +0200)]
testsuite: don't break on '+' in trusted-config-list path
Heiko Schlittermann (HS12-RIPE) [Wed, 28 Jun 2017 08:45:51 +0000 (10:45 +0200)]
Update Changelog about -p/-oMr
Phil Pennock [Tue, 27 Jun 2017 18:36:53 +0000 (14:36 -0400)]
Fix ChangeLog notice re manualroute option ordering
We do *NOT* permit options before hostnames. It's always hostnames
before options. It's _within_ the options that the use of a transport
name as an option name had been accidentally constrained to come last,
which was then fixed in commit
833c70bc.
I goofed in describing this.
Heiko Schlittermann (HS12-RIPE) [Tue, 27 Jun 2017 15:35:20 +0000 (17:35 +0200)]
Fix appendfile.c errmsg output that broke with d291c7
Phil Pennock [Mon, 26 Jun 2017 22:39:29 +0000 (18:39 -0400)]
Repair manualroute transport name not-last option
Commit
55414b25b did const-ification surgery which removed the old
"temporarily drop a NUL in here" anti-pattern, but one of the
Ustrcmp->Ustrncmp conversions was missed, for transport-name comparison.
As a result, since Exim 4.85, we've had an undocumented
requirement-by-bug that the transport name be the last such option
given. Restore old behaviour.
Still missing a test-case to deter regression.
Heiko Schlittermann (HS12-RIPE) [Sun, 25 Jun 2017 21:35:06 +0000 (23:35 +0200)]
Bail out if a configuration file starts with a byte order mark
Heiko Schlittermann (HS12-RIPE) [Sun, 25 Jun 2017 21:29:18 +0000 (23:29 +0200)]
Heiko Schlittermann (HS12-RIPE) [Sun, 25 Jun 2017 20:54:08 +0000 (22:54 +0200)]
Add quota/quota_filecount transport option modifier "no_check" Bug 1115
This option modifier allows to ignore the quota limits, but update
the maildirsize file.
Heiko Schlittermann (HS12-RIPE) [Sun, 25 Jun 2017 17:57:57 +0000 (19:57 +0200)]
Doc: check for w3m existence
w3m is called as non-last command in pipelines. A missing w3m
creates empty output and Make doesn't get it, because the last command
of the pipe (e.g. Tidytxt) doesn't return failure on empty input.