From: Phil Pennock <pdp@exim.org>
Date: Fri, 4 May 2012 02:18:34 +0000 (-0700)
Subject: spurious compiler warning of unused var fix
X-Git-Tag: exim-4_80_RC1~40^2~10
X-Git-Url: https://git.exim.org/exim.git/commitdiff_plain/0f5014860e54132a13e4ecc2f7f1859a9f3a971b?hp=da3ad30dcfbb4770835c2b7e165bb719f76cfc16

spurious compiler warning of unused var fix

(but added check in case wrong about spuriousness)
---

diff --git a/src/src/spam.c b/src/src/spam.c
index 0597084de..63395f2d5 100644
--- a/src/src/spam.c
+++ b/src/src/spam.c
@@ -27,7 +27,7 @@ int spam(uschar **listptr) {
   uschar user_name_buffer[128];
   unsigned long mbox_size;
   FILE *mbox_file;
-  int spamd_sock;
+  int spamd_sock = -1;
   uschar spamd_buffer[32600];
   int i, j, offset, result;
   uschar spamd_version[8];
@@ -220,6 +220,14 @@ int spam(uschar **listptr) {
 
   }
 
+  if (spamd_sock == -1) {
+    log_write(0, LOG_MAIN|LOG_PANIC,
+        "programming fault, spamd_sock unexpectedly unset");
+    (void)fclose(mbox_file);
+    (void)close(spamd_sock);
+    return DEFER;
+  }
+
   /* now we are connected to spamd on spamd_sock */
   (void)string_format(spamd_buffer,
            sizeof(spamd_buffer),